Re: comments for c/s 25919 Xen mce

[Christoph Egger <Christoph.Egger@amd.com>]

On 09/21/12 08:44, Liu, Jinsong wrote:

> Christoph, Keir, Jan
> 
> I have a draft look at c/s 25919. It moves some mce_intel.c logic to mce.c (and remove old mce.c logic). By draft reviewing the patch I think it need more work to do, and currently it in fact would hung at AMD platform (I have no AMD platform to test), i.e, MACHINE_CHECK_SOFTIRQ --> mce_delayed_action() --> mce_action() --> ASSERT(handler_num);
> 
> For AMD mce it may need add (if any misunderstanding please point to me)
> 1). add default handler which used at softirq context


This is mcee_softirq().

> 2). add AMD vmce inject logic


Yes, patch is sent.
See http://lists.xen.org/archives/html/xen-devel/2012-09/msg01413.html

> 3). more test


There are more patches in my queue.

Christoph

> 
> Thoughts?
> 
> Thanks,
> Jinsong



-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632