From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:50310)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1TEyjZ-00012z-5a
	for qemu-devel@nongnu.org; Fri, 21 Sep 2012 04:37:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1TEyjY-0000bE-5j
	for qemu-devel@nongnu.org; Fri, 21 Sep 2012 04:37:13 -0400
Received: from isrv.corpit.ru ([86.62.121.231]:34736)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1TEyjX-0000aY-V7
	for qemu-devel@nongnu.org; Fri, 21 Sep 2012 04:37:12 -0400
Message-ID: <505C272E.9090108@msgid.tls.msk.ru>
Date: Fri, 21 Sep 2012 12:37:02 +0400
From: Michael Tokarev <mjt@tls.msk.ru>
MIME-Version: 1.0
References: <1348186688-29410-1-git-send-email-jcmvbkbc@gmail.com>
	<1348186688-29410-3-git-send-email-jcmvbkbc@gmail.com>
In-Reply-To: <1348186688-29410-3-git-send-email-jcmvbkbc@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/2] tcg: add TB sanity checking
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>, Richard Henderson <rth@twiddle.net>

On 21.09.2012 04:18, Max Filippov wrote:

> diff --git a/tcg/tcg.c b/tcg/tcg.c

> +#ifdef CONFIG_DEBUG_TCG
> +static void tcg_sanity_check(TCGContext *s)

#ifndef CONFIG_DEBUG_TCG
#define tcg_sanity_check(s) /*empty*/
#else
static void tcg_sanity_check(TCGContext *s)

> +{
[]
> +}
> +#endif

> @@ -2082,6 +2147,10 @@ static inline int tcg_gen_code_common(TCGContext *s, uint8_t *gen_code_buf,
> +#ifdef CONFIG_DEBUG_TCG
> +    tcg_sanity_check(s);
> +#endif

And here we can drop the #ifdef.  FWIW.

/mjt