From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ying Xue Subject: Re: [PATCH] iscsi: Don't disable BH on BH context Date: Fri, 21 Sep 2012 17:16:21 +0800 Message-ID: <505C3065.9040802@windriver.com> References: <1345512507-8257-1-git-send-email-ying.xue@windriver.com> <7B2DD735-D51F-4037-A651-2E02684DFFD1@cs.wisc.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail1.windriver.com ([147.11.146.13]:61680 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932212Ab2IUJQV (ORCPT ); Fri, 21 Sep 2012 05:16:21 -0400 In-Reply-To: <7B2DD735-D51F-4037-A651-2E02684DFFD1@cs.wisc.edu> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Michael Christie Cc: linux-scsi@vger.kernel.org Michael Christie wrote: > On Aug 20, 2012, at 8:28 PM, Ying Xue wrote: > > >> Since we have already in BH context when iscsi_sw_tcp_write_space() >> is called, it's unnecessary to disable BH. >> > > Hey, > > I do don't think this is right anymore. It looks like it can be called in sock_setsockopt. > > I just finds it seems this is an unnecessary action to disable BH on BH context when I look through iscsi code. If you can confirm the iscsi_sw_tcp_write_space() is also called in process context, please ignore the noise. Regards, Ying >> Signed-off-by: Ying Xue >> Acked-by: Michael Christie >> --- >> drivers/scsi/iscsi_tcp.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c >> index 9220861..d763857 100644 >> --- a/drivers/scsi/iscsi_tcp.c >> +++ b/drivers/scsi/iscsi_tcp.c >> @@ -194,7 +194,7 @@ static void iscsi_sw_tcp_write_space(struct sock *sk) >> struct iscsi_sw_tcp_conn *tcp_sw_conn; >> void (*old_write_space)(struct sock *); >> >> - read_lock_bh(&sk->sk_callback_lock); >> + read_lock(&sk->sk_callback_lock); >> conn = sk->sk_user_data; >> if (!conn) { >> read_unlock_bh(&sk->sk_callback_lock); >> @@ -204,7 +204,7 @@ static void iscsi_sw_tcp_write_space(struct sock *sk) >> tcp_conn = conn->dd_data; >> tcp_sw_conn = tcp_conn->dd_data; >> old_write_space = tcp_sw_conn->old_write_space; >> - read_unlock_bh(&sk->sk_callback_lock); >> + read_unlock(&sk->sk_callback_lock); >> >> old_write_space(sk); >> >> -- >> 1.7.11 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > > >