All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerlando Falauto <gerlando.falauto@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Subject: [PATCH] Fix for bug in memory sizing code
Date: Fri, 21 Sep 2012 13:15:59 +0200	[thread overview]
Message-ID: <505C4C6F.9040905@keymile.com> (raw)
In-Reply-To: <20120918190629.GM19861@bill-the-cat>

Hi,

this patch actually breaks the mpc83xx board I am currently working on, 
leading to a detected size of 2 GiB (as opposed to the actual size of 
128 MiB).
I tried reviewing it and couldn't really figure out why, as it seems 
legitimate, and I currently don't have a chance to check it on other boards.
But I just tripled checked it and I am sure it's the root cause of my 
AAAAAAAAAAAARGGGGGGGGGGGHHHHHHHHHHHHHHHH! :-)

Anyone ever tried it?

Thanks,
Gerlando



On 09/18/2012 09:06 PM, Tom Rini wrote:
> On Sun, Sep 09, 2012 at 08:16:58PM -0000, Iwo Mergler wrote:
>
>> The original memory sizing code in get_ram_size clobbers the word
>> at the base address, but forgets to restore it.
>>
>> Signed-off-by: Iwo Mergler<Iwo.Mergler@netcommwireless.com>
>
> Applied to u-boot/master, thanks!
>
>
>
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

  reply	other threads:[~2012-09-21 11:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-10  6:16 [U-Boot] Subject: [PATCH] Fix for bug in memory sizing code Iwo Mergler
2012-09-18 19:06 ` Tom Rini
2012-09-21 11:15   ` Gerlando Falauto [this message]
2012-09-21 15:16     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=505C4C6F.9040905@keymile.com \
    --to=gerlando.falauto@keymile.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.