From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51698) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TF806-0000nT-TC for qemu-devel@nongnu.org; Fri, 21 Sep 2012 14:30:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TF805-0006Sf-HS for qemu-devel@nongnu.org; Fri, 21 Sep 2012 14:30:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64323) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TF805-0006SU-7V for qemu-devel@nongnu.org; Fri, 21 Sep 2012 14:30:53 -0400 Message-ID: <505CB259.40102@redhat.com> Date: Fri, 21 Sep 2012 12:30:49 -0600 From: Eric Blake MIME-Version: 1.0 References: <1348247243-12446-1-git-send-email-lcapitulino@redhat.com> <1348247243-12446-3-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1348247243-12446-3-git-send-email-lcapitulino@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig9C4DBF4888DE9975E236B2FD" Subject: Re: [Qemu-devel] [PATCH 2/3] qmp: dump-guest-memory: don't spin if non-blocking fd would block List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: jan.kiszka@siemens.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, d.hatayama@jp.fujitsu.com, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig9C4DBF4888DE9975E236B2FD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/21/2012 11:07 AM, Luiz Capitulino wrote: > fd_write_vmcore() will indefinitely spin for a non-blocking > file-descriptor that would block. However, if the fd is non-blocking, > how does it make sense to spin? >=20 > Change this behavior to return an error instead. >=20 > Note that this can only happen with an fd provided by a management > application. The fd opened internally by dump-guest-memory is blocking.= >=20 > Signed-off-by: Luiz Capitulino > --- > dump.c | 13 +++---------- > 1 file changed, 3 insertions(+), 10 deletions(-) >=20 > diff --git a/dump.c b/dump.c > index 2bf8d8d..5eea015 100644 > --- a/dump.c > +++ b/dump.c > @@ -100,18 +100,11 @@ static void dump_error(DumpState *s, const char *= reason) > static int fd_write_vmcore(void *buf, size_t size, void *opaque) > { > DumpState *s =3D opaque; > - int fd =3D s->fd; > size_t writen_size; While you are here, s/writen/written/ in the local variable. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig9C4DBF4888DE9975E236B2FD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQXLJZAAoJEKeha0olJ0NqRewH/Rc6MExqSU//8CMVBfNC5OwS BD5rUAa4oEqGT3sfaKfbrmb2bC2QPq+i8wChNuyDg+zfsNMKoE0HtIl1pktIUIjg /rvsBkgMn5+/N+t6vB6EZ3mWBG96/ph3FqxwRa3OO3aXXIAtrF1bhX6NxzR5ae2S g14QsEqvpormlptkOXoKQohAHl3k443CICQ0WTR/PpaUqoBmZOw+Md0e6or5omaR MQE4AiU4iaAi0V8FzaiRgB22kjcveMLK92iFE9NmCguQnXG8DHw0CfuQM0Qd+jbk GU0mfQW1myzXghcesQ6MjxHc1XBktybraDJoYgVcdr4EI56dmYcSMlKotG5V3yI= =l81Q -----END PGP SIGNATURE----- --------------enig9C4DBF4888DE9975E236B2FD--