diff for duplicates of <505CB869.5030307@wwwdotorg.org> diff --git a/a/1.txt b/N1/1.txt index a53b476..5e46e03 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -8,8 +8,8 @@ On 09/20/2012 02:53 AM, Tomasz Figa wrote: > +++ b/arch/arm/boot/dts/exynos4210-pinctrl-banks.dtsi > +/ { -> + pinctrl@11400000 { -> + gpa0: pin-bank@0 { +> + pinctrl at 11400000 { +> + gpa0: pin-bank at 0 { If you're going to put a unit address ("@0")into the DT node name, the node should have a reg property containing the same value, and the @@ -17,7 +17,7 @@ parent node should have #address-cells and #size-cells properties. However, I believe you can actually get unique node names without using a unit address; instead name the nodes after the object they represent, -so e.g. s/pin-bank@0/gpa0/ above. +so e.g. s/pin-bank at 0/gpa0/ above. > + gpio-controller; @@ -60,14 +60,14 @@ assume that's hard-coded as 4 right now. You need a #interrupt-cells property too. -> + gpd0: pin-bank@5 { +> + gpd0: pin-bank at 5 { > + gpio-controller; > + samsung,pctl-offset = <0x0A0>; I think hex number are usually lower-case in DT, but I may be extrapolating a generality from a limited set of examples. -> + gpy5: pin-bank@19{ +> + gpy5: pin-bank at 19{ Missing a space before the { there. diff --git a/a/content_digest b/N1/content_digest index f0ce0a3..5904e01 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,17 +1,9 @@ "ref\01348131197-25506-1-git-send-email-t.figa@samsung.com\0" "ref\01348131197-25506-7-git-send-email-t.figa@samsung.com\0" - "From\0Stephen Warren <swarren@wwwdotorg.org>\0" - "Subject\0Re: [RFC 6/6] ARM: dts: exynos4210: Add platform-specific descriptions for pin controllers\0" + "From\0swarren@wwwdotorg.org (Stephen Warren)\0" + "Subject\0[RFC 6/6] ARM: dts: exynos4210: Add platform-specific descriptions for pin controllers\0" "Date\0Fri, 21 Sep 2012 12:56:41 -0600\0" - "To\0Tomasz Figa <t.figa@samsung.com>\0" - "Cc\0linux-arm-kernel@lists.infradead.org" - kgene.kim@samsung.com - devicetree-discuss@lists.ozlabs.org - kyungmin.park@samsung.com - linux-samsung-soc@vger.kernel.org - thomas.abraham@linaro.org - linus.walleij@linaro.org - " m.szyprowski@samsung.com\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On 09/20/2012 02:53 AM, Tomasz Figa wrote:\n" @@ -24,8 +16,8 @@ "> +++ b/arch/arm/boot/dts/exynos4210-pinctrl-banks.dtsi\n" "\n" "> +/ {\n" - "> +\tpinctrl@11400000 {\n" - "> +\t\tgpa0: pin-bank@0 {\n" + "> +\tpinctrl at 11400000 {\n" + "> +\t\tgpa0: pin-bank at 0 {\n" "\n" "If you're going to put a unit address (\"@0\")into the DT node name, the\n" "node should have a reg property containing the same value, and the\n" @@ -33,7 +25,7 @@ "\n" "However, I believe you can actually get unique node names without using\n" "a unit address; instead name the nodes after the object they represent,\n" - "so e.g. s/pin-bank@0/gpa0/ above.\n" + "so e.g. s/pin-bank at 0/gpa0/ above.\n" "\n" "> +\t\t\tgpio-controller;\n" "\n" @@ -76,14 +68,14 @@ "\n" "You need a #interrupt-cells property too.\n" "\n" - "> +\t\tgpd0: pin-bank@5 {\n" + "> +\t\tgpd0: pin-bank at 5 {\n" "> +\t\t\tgpio-controller;\n" "> +\t\t\tsamsung,pctl-offset = <0x0A0>;\n" "\n" "I think hex number are usually lower-case in DT, but I may be\n" "extrapolating a generality from a limited set of examples.\n" "\n" - "> +\t\tgpy5: pin-bank@19{\n" + "> +\t\tgpy5: pin-bank at 19{\n" "\n" "Missing a space before the { there.\n" "\n" @@ -115,4 +107,4 @@ "that aggregates all the banks together, whereas samsung,eint-offset is\n" per-bank? -16766dd297c7f362465554cd1595d6cfea5f983b3296bf696426ac8ac274cfd5 +25320b4bcc704caf54ff9fced1b22a8f16ae9c67c3401cd1df8d21358b925749
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.