From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33621)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1TF9jm-0005ro-BB
	for qemu-devel@nongnu.org; Fri, 21 Sep 2012 16:22:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1TF9jH-0008No-EN
	for qemu-devel@nongnu.org; Fri, 21 Sep 2012 16:22:10 -0400
Message-ID: <505CCC4F.2050007@weilnetz.de>
Date: Fri, 21 Sep 2012 22:21:35 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <CAAu8pHsgTnKcAhUaNB+feFJkioz=3gmewV+HDdRHTK1j+PDSZw@mail.gmail.com>
	<1347895732-22212-1-git-send-email-rth@twiddle.net>
	<1347895732-22212-14-git-send-email-rth@twiddle.net>
	<505746E1.4080509@suse.de>
In-Reply-To: <505746E1.4080509@suse.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 13/13] tcg: Fix !USE_DIRECT_JUMP
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Cc: blauwirbel@gmail.com, qemu-stable@nongnu.org, qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>, Richard Henderson <rth@twiddle.net>

Am 17.09.2012 17:50, schrieb Andreas F=E4rber:
> Am 17.09.2012 17:28, schrieb Richard Henderson:
>> Commit 6375e09e changed the type of TranslationBlock.tb_next,
>> but failed to change the type of TCGContext.tb_next.
>>
>> Signed-off-by: Richard Henderson<rth@twiddle.net>
>
> Reviewed-by: Andreas F=E4rber<afaerber@suse.de>
>
> /-F
>
>> ---
>>   tcg/tcg.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tcg/tcg.h b/tcg/tcg.h
>> index 7a72729..21016ec 100644
>> --- a/tcg/tcg.h
>> +++ b/tcg/tcg.h
>> @@ -343,7 +343,7 @@ struct TCGContext {
>>
>>       /* goto_tb support */
>>       uint8_t *code_buf;
>> -    unsigned long *tb_next;
>> +    uintptr_t *tb_next;
>>       uint16_t *tb_next_offset;
>>       uint16_t *tb_jmp_offset; /* !=3D NULL if USE_DIRECT_JUMP */

Thanks for fixing and reviewing this issue.

I expect problems caused by the wrong old code for w64 hosts
when QEMU is run with more than 4 GiB (that's a rare scenario
because it is much slower than QEMU with kvm on Linux).

All UNIX/Linux based hosts and also w32 hosts are unharmed.

Nevertheless I suggest to apply the patch to QEMU 1.2 as well.

Regards

Stefan Weil