From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41438) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFCTA-0005hw-4l for qemu-devel@nongnu.org; Fri, 21 Sep 2012 19:17:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TFCT9-0006oI-9n for qemu-devel@nongnu.org; Fri, 21 Sep 2012 19:17:11 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:57852) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TFCT9-0006oD-3P for qemu-devel@nongnu.org; Fri, 21 Sep 2012 19:17:11 -0400 Received: by pbbrp12 with SMTP id rp12so8667437pbb.4 for ; Fri, 21 Sep 2012 16:17:10 -0700 (PDT) Sender: Richard Henderson Message-ID: <505CF574.80901@twiddle.net> Date: Fri, 21 Sep 2012 16:17:08 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1348256598-8146-1-git-send-email-aurelien@aurel32.net> <1348256598-8146-8-git-send-email-aurelien@aurel32.net> In-Reply-To: <1348256598-8146-8-git-send-email-aurelien@aurel32.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 07/10] tcg/optimize: further optimize brcond/movcond/setcond List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: qemu-devel@nongnu.org On 09/21/2012 12:43 PM, Aurelien Jarno wrote: > +/* Return 2 if the condition can't be simplified, and the result > + of the condition (0 or 1) if it can */ Ok as-is. But I'd bike-shed the "fail" return to -1. r~