Re: [Qemu-devel] [PATCH] audio: Fix warning from static code analysis

[Stefan Weil <sw@weilnetz.de>]

Am 03.09.2012 21:25, schrieb Stefan Weil:
> smatch report:
> audio/audio_template.h:416 AUD_open_out(18) warn:
>   variable dereferenced before check 'as' (see line 414)
>
> Moving the ldebug statement after the statement which checks 'as'
> fixes that warning.
>
> Signed-off-by: Stefan Weil<sw@weilnetz.de>
> ---
>
> This patch fails when checked by checkpatch.pl because
> it preserves the coding style used for QEMU audio code.
>
> Please apply the patch after QEMU 1.2 was released.
>
> Thanks,
>
> Stefan Weil
>
>   audio/audio_template.h |    6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/audio/audio_template.h b/audio/audio_template.h
> index 519432a..16f7880 100644
> --- a/audio/audio_template.h
> +++ b/audio/audio_template.h
> @@ -410,15 +410,15 @@ SW *glue (AUD_open_, TYPE) (
>       SW *old_sw = NULL;
>   #endif
>
> -    ldebug ("open %s, freq %d, nchannels %d, fmt %d\n",
> -            name, as->freq, as->nchannels, as->fmt);
> -
>       if (audio_bug (AUDIO_FUNC, !card || !name || !callback_fn || !as)) {
>           dolog ("card=%p name=%p callback_fn=%p as=%p\n",
>                  card, name, callback_fn, as);
>           goto fail;
>       }
>
> +    ldebug ("open %s, freq %d, nchannels %d, fmt %d\n",
> +            name, as->freq, as->nchannels, as->fmt);
> +
>       if (audio_bug (AUDIO_FUNC, audio_validate_settings (as))) {
>           audio_print_settings (as);
>           goto fail;
>    

Ping?