From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54034)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1TFXOf-0003m6-RN
	for qemu-devel@nongnu.org; Sat, 22 Sep 2012 17:37:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1TFXOe-0005Nw-Tg
	for qemu-devel@nongnu.org; Sat, 22 Sep 2012 17:37:57 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:56161)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1TFXOe-0005Ns-N5
	for qemu-devel@nongnu.org; Sat, 22 Sep 2012 17:37:56 -0400
Message-ID: <505E2FB3.9020107@weilnetz.de>
Date: Sat, 22 Sep 2012 23:37:55 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1347642150-4710-1-git-send-email-sw@weilnetz.de>
In-Reply-To: <1347642150-4710-1-git-send-email-sw@weilnetz.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] configure: Allow builds without any system
	or user emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: laurent.desnogues@gmail.com, Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org

Am 14.09.2012 19:02, schrieb Stefan Weil:
> The old code aborted configure when no emulation target was selected.
> Even after removing the 'exit 1', it tried to read from STDIN
> when QEMU was configured with
>
>      configure' '--disable-user' '--disable-system'
>
> This is fixed here.
>
> Signed-off-by: Stefan Weil<sw@weilnetz.de>
> ---
>
> This patch can be applied after 66d5499b3 was reverted.
>
> It also works on top of 66d5499b3. In this case only Makefile
> needs modifications, and the configure part of the patch must be removed.
>
> Regards
>
> Stefan Weil
>
>
>   Makefile  |    5 +++++
>   configure |    4 ----
>   2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 9523e05..d38ac0f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -52,8 +52,13 @@ SUBDIR_MAKEFLAGS=$(if $(V),,--no-print-directory) BUILD_DIR=$(BUILD_DIR)
>   SUBDIR_DEVICES_MAK=$(patsubst %, %/config-devices.mak, $(TARGET_DIRS))
>   SUBDIR_DEVICES_MAK_DEP=$(patsubst %, %/config-devices.mak.d, $(TARGET_DIRS))
>
> +ifeq ($(SUBDIR_DEVICES_MAK),)
> +config-all-devices.mak:
> +	$(call quiet-command,echo '# no devices'>  $@,"  GEN   $@")
> +else
>   config-all-devices.mak: $(SUBDIR_DEVICES_MAK)
>   	$(call quiet-command,cat $(SUBDIR_DEVICES_MAK) | grep =y | sort -u>  $@,"  GEN   $@")
> +endif
>
>   -include $(SUBDIR_DEVICES_MAK_DEP)
>
> diff --git a/configure b/configure
> index fc27bd9..a9305f3 100755
> --- a/configure
> +++ b/configure
> @@ -1331,10 +1331,6 @@ if test -z "$target_list" ; then
>   else
>       target_list=`echo "$target_list" | sed -e 's/,/ /g'`
>   fi
> -if test -z "$target_list" ; then
> -    echo "No targets enabled"
> -    exit 1
> -fi
>   # see if system emulation was really requested
>   case " $target_list " in
>     *"-softmmu "*) softmmu=yes
>    


Ping? 66d5499b3 was reverted, so my patch can be applied if nobody objects.

Thanks,

Stefan Weil