From: Avi Kivity <avi@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: akong@redhat.com, qemu-devel@nongnu.org,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/3] qmp: qmp_send_key(): accept key codes in hex
Date: Sun, 23 Sep 2012 10:49:07 +0200 [thread overview]
Message-ID: <505ECD03.6000107@redhat.com> (raw)
In-Reply-To: <505CAFD4.2000708@redhat.com>
On 09/21/2012 09:20 PM, Eric Blake wrote:
> On 09/21/2012 12:18 PM, Eric Blake wrote:
> >> Any better ideas?
> >
> > Maybe s/hex/number/, as in:
> >
> > JSON: 'number':0x20
> >
> > C code: keylist->value->number = number;
> >
> > that is, you are passing the value either as a keycode name, or as a number.
>
> Or even s/hex/int/
>
> except that the C code would then have to use mangling (since the JSON
> name would match a C keyword).
>
'keycode'?
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2012-09-23 8:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 14:55 [Qemu-devel] [PATCH v2 0/3]: qmp: send-key: accept key codes in hex Luiz Capitulino
2012-09-21 14:55 ` [Qemu-devel] [PATCH 1/3] input: qmp_send_key(): simplify Luiz Capitulino
2012-09-21 14:55 ` [Qemu-devel] [PATCH 2/3] qmp: qmp_send_key(): accept key codes in hex Luiz Capitulino
2012-09-21 16:31 ` Eric Blake
2012-09-21 16:42 ` Luiz Capitulino
2012-09-21 17:26 ` Luiz Capitulino
2012-09-21 18:18 ` Eric Blake
2012-09-21 18:20 ` Eric Blake
2012-09-23 8:49 ` Avi Kivity [this message]
2012-09-21 18:20 ` Markus Armbruster
2012-09-21 14:55 ` [Qemu-devel] [PATCH 3/3] input: index_from_key(): drop unused code Luiz Capitulino
2012-09-21 16:32 ` [Qemu-devel] [PATCH v2 0/3]: qmp: send-key: accept key codes in hex Eric Blake
-- strict thread matches above, loose matches on Subject: below --
2012-09-26 20:25 [Qemu-devel] [PATCH v3 0/3] " Luiz Capitulino
2012-09-26 20:25 ` [Qemu-devel] [PATCH 2/3] qmp: qmp_send_key(): " Luiz Capitulino
2012-09-27 11:42 ` Markus Armbruster
2012-09-27 12:57 ` Luiz Capitulino
2012-09-20 18:17 [Qemu-devel] [PATCH 0/3]: qmp: send-key: " Luiz Capitulino
2012-09-20 18:18 ` [Qemu-devel] [PATCH 2/3] qmp: qmp_send_key(): " Luiz Capitulino
2012-09-20 20:36 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505ECD03.6000107@redhat.com \
--to=avi@redhat.com \
--cc=akong@redhat.com \
--cc=eblake@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.