From: Hans de Goede <hdegoede@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: shawn.starr@rogers.com, Gerd Hoffmann <kraxel@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ehci: Fix interrupt packet MULT handling
Date: Sun, 23 Sep 2012 12:06:04 +0200 [thread overview]
Message-ID: <505EDF0C.1050500@redhat.com> (raw)
In-Reply-To: <CAAu8pHt8WEq_qMZs44NHwRj1_f0Fr7OvKtuWHfKxF76QApzd7A@mail.gmail.com>
Hi,
Sorry.
On 09/22/2012 03:16 PM, Blue Swirl wrote:
> On Thu, Sep 20, 2012 at 3:38 PM, Hans de Goede <hdegoede@redhat.com> wrote:
<snip>
>> @@ -1837,6 +1838,10 @@ static EHCIQueue *ehci_state_fetchqh(EHCIState *ehci, int async)
>> }
>> q->qh = qh;
>>
>> + q->transact_ctr = get_field(q->qh.epcap, QH_EPCAP_MULT);
>> + if (q->transact_ctr == 0) /* Guest bug in some versions of windows */
>> + q->transact_ctr = 4;
>
> Missing braces, please use checkpatch.pl.
>
Oops, Gerd since this is already in your tree, can you fix this, or do you
want a new fixed version ?
Regards,
Hans
next prev parent reply other threads:[~2012-09-23 9:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 15:38 [Qemu-devel] [PATCH] ehci: Fix interrupt packet MULT handling Hans de Goede
2012-09-21 7:02 ` Gerd Hoffmann
2012-09-22 13:16 ` Blue Swirl
2012-09-23 10:06 ` Hans de Goede [this message]
2012-09-24 6:10 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505EDF0C.1050500@redhat.com \
--to=hdegoede@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=shawn.starr@rogers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.