From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] video: bf*: Add missing spinlock init
Date: Sun, 23 Sep 2012 19:42:40 +0000 [thread overview]
Message-ID: <505F6630.5040608@gmx.de> (raw)
In-Reply-To: <20120906092311.22961acd@endymion.delvare>
On 09/06/2012 07:23 AM, Jean Delvare wrote:
> It doesn't seem these spinlocks were properly initialized.
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Applied. Looks correct to me.
Thanks,
Florian Tobias Schandinat
> ---
> I can't even build-test this.
>
> drivers/video/bf54x-lq043fb.c | 1 +
> drivers/video/bfin-lq035q1-fb.c | 1 +
> drivers/video/bfin-t350mcqb-fb.c | 1 +
> 3 files changed, 3 insertions(+)
>
> --- linux-3.6-rc4.orig/drivers/video/bf54x-lq043fb.c 2012-07-21 22:58:29.000000000 +0200
> +++ linux-3.6-rc4/drivers/video/bf54x-lq043fb.c 2012-09-06 08:49:37.812899185 +0200
> @@ -525,6 +525,7 @@ static int __devinit bfin_bf54x_probe(st
> info = fbinfo->par;
> info->fb = fbinfo;
> info->dev = &pdev->dev;
> + spin_lock_init(&info->lock);
>
> platform_set_drvdata(pdev, fbinfo);
>
> --- linux-3.6-rc4.orig/drivers/video/bfin-lq035q1-fb.c 2012-07-21 22:58:29.000000000 +0200
> +++ linux-3.6-rc4/drivers/video/bfin-lq035q1-fb.c 2012-09-06 08:48:50.618858480 +0200
> @@ -577,6 +577,7 @@ static int __devinit bfin_lq035q1_probe(
> info = fbinfo->par;
> info->fb = fbinfo;
> info->dev = &pdev->dev;
> + spin_lock_init(&info->lock);
>
> info->disp_info = pdev->dev.platform_data;
>
> --- linux-3.6-rc4.orig/drivers/video/bfin-t350mcqb-fb.c 2012-07-21 22:58:29.000000000 +0200
> +++ linux-3.6-rc4/drivers/video/bfin-t350mcqb-fb.c 2012-09-06 08:48:12.310825601 +0200
> @@ -447,6 +447,7 @@ static int __devinit bfin_t350mcqb_probe
> info = fbinfo->par;
> info->fb = fbinfo;
> info->dev = &pdev->dev;
> + spin_lock_init(&info->lock);
>
> platform_set_drvdata(pdev, fbinfo);
>
>
>
prev parent reply other threads:[~2012-09-23 19:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 7:23 [PATCH] video: bf*: Add missing spinlock init Jean Delvare
2012-09-23 19:42 ` Florian Tobias Schandinat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505F6630.5040608@gmx.de \
--to=florianschandinat@gmx.de \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.