All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 2/2] video: s3c2410: fix checkpatch warnings
Date: Sun, 23 Sep 2012 19:46:27 +0000	[thread overview]
Message-ID: <505F6713.3070504@gmx.de> (raw)
In-Reply-To: <002d01cd8f42$c06b6690$414233b0$%han@samsung.com>

On 09/10/2012 10:55 AM, Jingoo Han wrote:
> This patch fixes the checkpatch warnings listed below:
> 
> WARNING: usleep_range should not use min = max args; see Documentation/timers/timers-howto.txt
> WARNING: quoted string split across lines
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>

Applied.


Thanks,

Florian Tobias Schandinat

> ---
>  drivers/video/s3c2410fb.c |   12 ++++++------
>  1 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/video/s3c2410fb.c b/drivers/video/s3c2410fb.c
> index 1aa37ea..1083bb9 100644
> --- a/drivers/video/s3c2410fb.c
> +++ b/drivers/video/s3c2410fb.c
> @@ -935,7 +935,7 @@ static int __devinit s3c24xxfb_probe(struct platform_device *pdev,
>  	clk_enable(info->clk);
>  	dprintk("got and enabled clock\n");
>  
> -	usleep_range(1000, 1000);
> +	usleep_range(1000, 1100);
>  
>  	info->clk_rate = clk_get_rate(info->clk);
>  
> @@ -1034,7 +1034,7 @@ static int __devexit s3c2410fb_remove(struct platform_device *pdev)
>  	s3c2410fb_cpufreq_deregister(info);
>  
>  	s3c2410fb_lcd_enable(info, 0);
> -	usleep_range(1000, 1000);
> +	usleep_range(1000, 1100);
>  
>  	s3c2410fb_unmap_video_memory(fbinfo);
>  
> @@ -1071,7 +1071,7 @@ static int s3c2410fb_suspend(struct platform_device *dev, pm_message_t state)
>  	 * the LCD DMA engine is not going to get back on the bus
>  	 * before the clock goes off again (bjd) */
>  
> -	usleep_range(1000, 1000);
> +	usleep_range(1000, 1100);
>  	clk_disable(info->clk);
>  
>  	return 0;
> @@ -1083,7 +1083,7 @@ static int s3c2410fb_resume(struct platform_device *dev)
>  	struct s3c2410fb_info *info = fbinfo->par;
>  
>  	clk_enable(info->clk);
> -	usleep_range(1000, 1000);
> +	usleep_range(1000, 1100);
>  
>  	s3c2410fb_init_registers(fbinfo);
>  
> @@ -1140,8 +1140,8 @@ static void __exit s3c2410fb_cleanup(void)
>  module_init(s3c2410fb_init);
>  module_exit(s3c2410fb_cleanup);
>  
> -MODULE_AUTHOR("Arnaud Patard <arnaud.patard@rtp-net.org>, "
> -	      "Ben Dooks <ben-linux@fluff.org>");
> +MODULE_AUTHOR("Arnaud Patard <arnaud.patard@rtp-net.org>");
> +MODULE_AUTHOR("Ben Dooks <ben-linux@fluff.org>");
>  MODULE_DESCRIPTION("Framebuffer driver for the s3c2410");
>  MODULE_LICENSE("GPL");
>  MODULE_ALIAS("platform:s3c2410-lcd");


      reply	other threads:[~2012-09-23 19:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-10 10:55 [PATCH 2/2] video: s3c2410: fix checkpatch warnings Jingoo Han
2012-09-23 19:46 ` Florian Tobias Schandinat [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=505F6713.3070504@gmx.de \
    --to=florianschandinat@gmx.de \
    --cc=linux-fbdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.