Re: [PATCH] ov2640: select sensor register bank before applying h/v-flip settings

["Frank Schäfer" <fschaefer.oss@googlemail.com>]

Am 24.09.2012 00:33, schrieb Guennadi Liakhovetski:
> On Sun, 23 Sep 2012, Frank SchÀfer wrote:
>
>> We currently don't select the register bank in ov2640_s_ctrl, so we can end up
>> writing to DSP register 0x04 instead of sensor register 0x04.
>> This happens for example when calling ov2640_s_ctrl after ov2640_s_fmt.
>>
>> Signed-off-by: Frank SchÀfer <fschaefer.oss@googlemail.com>
>> Cc: stable@kernel.org
> Ok, if Linus decides to release 3.6 tomorrow, I anyway don't think it'd be 
> reasonable to try to convince him to pull this hours before the release:-) 
> So, I'll wait for those other 2 fixes from Peter Senna / coccinelle and 
> submit a normal fixes pull request some time tomorrow. Just wondering:

Sure.

>
>> ---
>>  drivers/media/i2c/soc_camera/ov2640.c |    5 +++++
>>  1 Datei geÀndert, 5 Zeilen hinzugefÌgt(+)
> are we soon going to see this line in all possible languages / alphabets / 
> logographic systems? ;-)

I don't know, I see this only in your replies, so it seems to be a
problem with your mail client ?

Regards,
Frank

>
> Thanks
> Guennadi
>
>> diff --git a/drivers/media/i2c/soc_camera/ov2640.c b/drivers/media/i2c/soc_camera/ov2640.c
>> index 78ac574..d2d298b 100644
>> --- a/drivers/media/i2c/soc_camera/ov2640.c
>> +++ b/drivers/media/i2c/soc_camera/ov2640.c
>> @@ -684,6 +684,11 @@ static int ov2640_s_ctrl(struct v4l2_ctrl *ctrl)
>>  		&container_of(ctrl->handler, struct ov2640_priv, hdl)->subdev;
>>  	struct i2c_client  *client = v4l2_get_subdevdata(sd);
>>  	u8 val;
>> +	int ret;
>> +
>> +	ret = i2c_smbus_write_byte_data(client, BANK_SEL, BANK_SEL_SENS);
>> +	if (ret < 0)
>> +		return ret;
>>  
>>  	switch (ctrl->id) {
>>  	case V4L2_CID_VFLIP:
>> -- 
>> 1.7.10.4
>>
> ---
> Guennadi Liakhovetski, Ph.D.
> Freelance Open-Source Software Developer
> http://www.open-technology.de/
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html