Re: tda8290 regression fix

[Anders Thomson <aeriksson2@gmail.com>]

On 2012-09-23 20:39, Anders Thomson wrote:
> On 2012-09-23 19:54, Anders Thomson wrote:
> >  >   diff --git a/drivers/media/pci/saa7134/saa7134-cards.c b/drivers/media/pci/saa7134/saa7134-cards.c
> >  >   index bc08f1d..98b482e 100644
> >  >   --- a/drivers/media/pci/saa7134/saa7134-cards.c
> >  >   +++ b/drivers/media/pci/saa7134/saa7134-cards.c
> >  >   @@ -3288,13 +3288,13 @@ struct saa7134_board saa7134_boards[] = {
> >  >     		.name           = "Pinnacle PCTV 310i",
> >  >     		.audio_clock    = 0x00187de7,
> >  >     		.tuner_type     = TUNER_PHILIPS_TDA8290,
> >  >     		.radio_type     = UNSET,
> >  >     		.tuner_addr     = ADDR_UNSET,
> >  >     		.radio_addr     = ADDR_UNSET,
> >  >   -		.tuner_config   = 1,
> >  >   +		.tuner_config   = 0,
> >  >     		.mpeg           = SAA7134_MPEG_DVB,
> >  >     		.gpiomask       = 0x000200000,
> >  >     		.inputs         = {{
> >  >     			.name = name_tv,
> >  >     			.vmux = 4,
> >  >     			.amux = TV,
> >  >
> >  >
> >  >   Please test if the above patch fixes the issue you're suffering[1]. If so, then
> >  >   we'll need to add a modprobe parameter to allow disabling LNA for saa7134 devices
> >  >   with LNA.
> >  >
> >  >   [1] Note: the above is not the fix, as some users of this board may be using the
> >  >   original antenna, and changing tuner_config will break things for them; the right
> >  >   fix is likely to allow controlling the LNA via userspace.
> >  Tried that patch on 3.5.3. No improvement, unfortunately.
> I have to retract that. It turns out that there is some strange interaction
> between the cabletv box and the card. When I rebooted into 'my' patch
> I still got the noisy signal. I then power cycled the cabletv box, and
> voila,
> I got a good signal on my own patch.
Awfully sorry about this. After having had the familty sit in and check 
the differences,
I must say that the patch does not fix the issue. This time around I 
have x11grabs with
ffmpeg to show if you want.

I'll be away from the card until the end of the coming week. Then, I'll 
bring out the multimeter...

Best regards,
/Anders