Re: [dracut] weird code in dracut-logger.sh

[Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

Hi,

I'm not sure about this issue. Sending to dracut mainling list.

On 09/23/2012 12:11 AM, Consus wrote:

> Hi,
> 
> I want to ask you about some piece of code I found lately in dracut-logger.sh:
> 
> 141 || if (( $sysloglvl >= 0 )); then
> 142 ||    if ! [ -S /dev/log -a -w /dev/log ] || ! command -v logger >/dev/null
> 143 ||    then
> 144 ||        # We cannot log to syslog, so turn this facility off.
> 145 ||        sysloglvl=0
> 
> I may be wrong, but this should be changed to (( $sysloglvl > 0 )). For
> now this code causes error messages even if this facility is disabled.
> For example, with fileloglvl=0 I'm getting 
> 
>     /usr/lib/dracut/dracut-logger.sh: line 122: : No such file or directory
> 
> on every dracut run (with -1 works fine). So I suggest either adding -1
> as "facility disabled" to documentation or rewriting these checks.
> 



-- 
Thanks
Dave