All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Liam Girdwood <lrg@ti.com>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the sound and sound-asoc trees
Date: Mon, 24 Sep 2012 10:52:17 +0300	[thread overview]
Message-ID: <50601131.10602@ti.com> (raw)
In-Reply-To: <s5hy5jzoo8d.wl%tiwai@suse.de>

On 09/24/2012 10:48 AM, Takashi Iwai wrote:
> At Mon, 24 Sep 2012 13:39:23 +1000,
> Stephen Rothwell wrote:
>>
>> Hi all,
>>
>> After merging the sound tree, today's linux-next build (powerpc
>> ppc64_defconfig) failed like this:
>>
>> In file included from include/linux/skbuff.h:31:0,
>>                  from include/linux/if_ether.h:135,
>>                  from include/linux/netdevice.h:29,
>>                  from arch/powerpc/net/bpf_jit_comp.c:14:
>> include/linux/dmaengine.h: In function 'dmaengine_prep_dma_cyclic':
>> include/linux/dmaengine.h:659:24: error: 'flags' undeclared (first use in this function)
>>
>> and lots more similar.
>>
>> Caused by commit ec8b5e48c037 ("dmaengine: Pass flags via
>> device_prep_dma_cyclic() callback").  Was this version of this patch
>> build tested at all?
>>
>> I have used the sound and sound-asoc trees from next-20120921 for today.
> 
> Ugh, sorry.  I skipped the ppc and arm build tests at the previous
> merge due to the remote work.
> 
> I can fix up but it'd be better to get a proper fix from Peter.
> Peter, could you submit the fix ASAP?

I already have the series to fix it.
The reason for the build breakage is that the following commit from my series
got lost somewhere:
dmaengine: Add flags parameter to dmaengine_prep_dma_cyclic()

I also noticed that arch/arm/plat-samsung/dma-ops.c calls
dmaengine_prep_dma_cyclic(), which was unexpected for me. So I have two patch
for linux-next/sound to fix the issue.

Will send them in a minute.

-- 
Péter

  reply	other threads:[~2012-09-24  7:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-24  3:39 linux-next: build failure after merge of the sound and sound-asoc trees Stephen Rothwell
2012-09-24  7:48 ` Takashi Iwai
2012-09-24  7:52   ` Peter Ujfalusi [this message]
2012-09-24  7:58 ` [PATCH 0/2] dmaengine: Fix compillation issues in device_prep_dma_cyclic() Peter Ujfalusi
2012-09-24  7:58   ` [PATCH 1/2] dmaengine: Add flags parameter to dmaengine_prep_dma_cyclic() Peter Ujfalusi
2012-09-24  7:58   ` [PATCH 2/2] ARM: SAMSUNG: dma-ops: Fix dmaengine_prep_dma_cyclic() parameter list Peter Ujfalusi
2012-09-24  8:17   ` [PATCH 0/2] dmaengine: Fix compillation issues in device_prep_dma_cyclic() Takashi Iwai
2012-09-24 18:08     ` Takashi Iwai
2012-09-25 11:19       ` Mark Brown
2012-09-25 11:19         ` [alsa-devel] " Mark Brown
2012-09-24  8:40   ` Vinod Koul
2012-10-12 16:44   ` [alsa-devel] " Tabi Timur-B04825
  -- strict thread matches above, loose matches on Subject: below --
2011-02-28  3:15 linux-next: build failure after merge of the sound and sound-asoc trees Stephen Rothwell
2011-02-28 14:34 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50601131.10602@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=sfr@canb.auug.org.au \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.