All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V4] i.MX6: mx6qsabrelite: Add splash screen support
Date: Mon, 24 Sep 2012 08:11:59 -0700	[thread overview]
Message-ID: <5060783F.50208@boundarydevices.com> (raw)
In-Reply-To: <50607620.50701@denx.de>

Sorry Stefano,

On 09/24/2012 08:02 AM, Stefano Babic wrote:
> On 22/09/2012 00:53, Eric Nelson wrote:
>> Adds support for two LVDS panels and one RGB panel to the SABRE-Lite
>> board:
>>       Hannstar-XGA	- 1024 x 768 LVDS (Freescale part number MCIMX-LVDS1)
>>       wsvga-lvds		- 1024 x 600 LVDS (Boundary p/n Nit6X_1024x600)
>>       wvga-rgb		- 800 x 480 RGB (Boundary p/n Nit6X_800x480)
>>
>> Auto-detects panel by probing the I2C touch controller of each.
>>
>> Setting 'panel' environment variable to one of the names above will override
>> auto-detection.
>>
>> Signed-off-by: Eric Nelson<eric.nelson@boundarydevices.com>
>> ---
>
>
>>   board/freescale/mx6qsabrelite/mx6qsabrelite.c |  245 ++++++++++++++++++++++++-
>>   drivers/video/ipu_common.c                    |    2 +-
>>   include/configs/mx6qsabrelite.h               |   15 ++-
>>   3 files changed, 259 insertions(+), 3 deletions(-)
>
> Between V3 and V4 you changed also ipu_common.c, and that change does
> not apply.
>
>>          /* address of boot parameters */
>> diff --git a/drivers/video/ipu_common.c b/drivers/video/ipu_common.c
>> index cc8f881..5f0a1a8 100644
>> --- a/drivers/video/ipu_common.c
>> +++ b/drivers/video/ipu_common.c
>> @@ -218,7 +218,7 @@ static struct clk ipu_clk = {
>>   #else
>>   	.enable_reg = (u32 *)(CCM_BASE_ADDR +
>>   		offsetof(struct mxc_ccm_reg, CCGR3)),
>> -	.enable_shift = MXC_CCM_CCGR3_IPU1_IPU_DI0_OFFSET,
>> +	.enable_shift = MXC_CCM_CCGR3_IPU1_IPU_MASK,
>
> But in ipu_common.c:
>
>          .enable_reg = (u32 *)(CCM_BASE_ADDR +
>                  offsetof(struct mxc_ccm_reg, CCGR5)),
>          .enable_shift = MXC_CCM_CCGR5_CG5_OFFSET,
>

CCGR5/CG5 is the IPU clock on i.MX5x, not i.MX6x.

> I do not see another patch changing that. Am I missing something ?
>

This patch requires the previous change to name the CCGRx bitfields:

	http://patchwork.ozlabs.org/patch/185856/

Regards,


Eric

  reply	other threads:[~2012-09-24 15:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-21 22:53 [U-Boot] [PATCH V4] i.MX6: mx6qsabrelite: Add splash screen support Eric Nelson
2012-09-22 15:12 ` Fabio Estevam
2012-09-22 16:51   ` Eric Nelson
2012-09-22 17:02     ` Fabio Estevam
2012-09-22 17:19       ` Eric Nelson
2012-09-23 22:53         ` Eric Nelson
2012-10-03  0:31           ` Eric Nelson
2012-10-03  8:09             ` Stefano Babic
2012-10-03 14:37               ` Eric Nelson
2012-10-03 15:06                 ` Eric Nelson
2012-10-03 15:22                   ` Stefano Babic
2012-09-24 15:02 ` Stefano Babic
2012-09-24 15:11   ` Eric Nelson [this message]
2012-09-24 15:21     ` Stefano Babic
2012-09-24 15:49       ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5060783F.50208@boundarydevices.com \
    --to=eric.nelson@boundarydevices.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.