From: Jeff Garzik <jgarzik@pobox.com>
To: Aaron Lu <aaron.lu@intel.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Oliver Neukum <oneukum@suse.de>, Aaron Lu <aaron.lwe@gmail.com>,
Jack Wang <jack_wang@usish.com>,
Shane Huang <shane.huang@amd.com>,
linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 1/4] scsi: introduce sync_before_stop flag
Date: Mon, 24 Sep 2012 18:13:19 -0400 [thread overview]
Message-ID: <5060DAFF.60904@pobox.com> (raw)
In-Reply-To: <20120918083138.GA1792@mint-spring.sh.intel.com>
On 09/18/2012 04:31 AM, Aaron Lu wrote:
> I agree that it is better handled in libata's SALT, I tried to do this
> but didn't find a good way so I introduced this flag. The SALT is 1-1
> mapping, I'm not sure how to handle this 1-2 mapping.
That is the crux of the matter: it is rather difficult within the
current code, if there is not a 1:1 correspondence between SCSI command
and ATA command.
The solution that works within libata-scsi.c involves creating two
ata_queued_cmd's, and managing the issuance and completion yourself.
But really -- the most practical route seems to be simply to set WCE, to
trigger the desired behavior.
Jeff
next prev parent reply other threads:[~2012-09-24 22:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 7:00 [PATCH v2 0/4] Support runtime power off of HDD Aaron Lu
2012-09-18 7:00 ` [PATCH v2 1/4] scsi: introduce sync_before_stop flag Aaron Lu
2012-09-18 7:30 ` Oliver Neukum
2012-09-18 7:47 ` Aaron Lu
2012-09-18 7:56 ` James Bottomley
2012-09-18 8:09 ` Aaron Lu
2012-09-18 8:20 ` James Bottomley
2012-09-18 8:31 ` Aaron Lu
2012-09-24 22:13 ` Jeff Garzik [this message]
2012-09-18 7:00 ` [PATCH v2 2/4] scsi: sd: enter stop power condition on runtime suspend Aaron Lu
2012-09-18 7:00 ` [PATCH v2 3/4] scsi: sd: set ready_to_power_off for scsi disk Aaron Lu
2012-09-18 7:00 ` [PATCH v2 4/4] libata: acpi: set can_power_off for both ODD and HDD Aaron Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5060DAFF.60904@pobox.com \
--to=jgarzik@pobox.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=aaron.lu@intel.com \
--cc=aaron.lwe@gmail.com \
--cc=jack_wang@usish.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=oneukum@suse.de \
--cc=shane.huang@amd.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.