From: Wang Sheng-Hui <shhuiw@gmail.com>
To: linux-btrfs@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH 4/4] Btrfs: tivial cleanup: add space between = and the rest code
Date: Tue, 25 Sep 2012 08:01:01 +0800 [thread overview]
Message-ID: <5060F43D.3000801@gmail.com> (raw)
In-Reply-To: <20120924131531.GE14582@twin.jikos.cz>
On 2012年09月24日 21:15, David Sterba wrote:
> On Mon, Sep 24, 2012 at 08:47:33AM +0800, Wang Sheng-Hui wrote:
>> trivial code cleanup.
>
>> - ret =btrfs_drop_snapshot(root, NULL, 1, 0);
>> + ret = btrfs_drop_snapshot(root, NULL, 1, 0);
>
> Sorry but this is too trivial.
>
> Unless it really bugs you when you're going through code, I don't think
> that cleanups at this level are necessary. Reading through commit
> history of some code via 'git blame' and seeing such cleanups is not
> welcome.
>
Got it. Thanks,
> I have a patchet in testing that updates a few things around snapshot
> cleaning and this line will get fixed, so it'll not stay forever.
>
> david
prev parent reply other threads:[~2012-09-25 0:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 0:47 [PATCH 4/4] Btrfs: tivial cleanup: add space between = and the rest code Wang Sheng-Hui
2012-09-24 13:15 ` David Sterba
2012-09-25 0:01 ` Wang Sheng-Hui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5060F43D.3000801@gmail.com \
--to=shhuiw@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.