From: Arjan van de Ven <arjan at linux.intel.com>
To: powertop@lists.01.org
Subject: Re: [Powertop] [PATCH v2 1/2] Updates to support Android platform
Date: Tue, 25 Sep 2012 07:45:24 +0200 [thread overview]
Message-ID: <506144F4.70007@linux.intel.com> (raw)
In-Reply-To: CA+Z25wV9QXDp9zmaoQrxXUh6VGMBs0Rb3=tNd-xnT50HPz2Uqg@mail.gmail.com
[-- Attachment #1: Type: text/plain, Size: 1298 bytes --]
On 9/25/2012 7:34 AM, Rajagopal Venkat wrote:
>> On 09/24/2012 06:28 AM, Rajagopal Venkat wrote:
>>>
>>> This patch adds following minor changes to prepare powertop
>>> to support Android platform.
>>>
>>> - Add missing HAVE_CONFIG_H conditional check.
>>> - remove un-used ethtool_cmd_speed_set and ethtool_cmd_speed
>>> functions.
>>> - Minimize dependency on exception handling in catch blocks.
>>>
>>> These changes will not affect powertop functionality.
>>>
>>> Signed-off-by: Rajagopal Venkat <rajagopal.venkat(a)linaro.org>
>>
> As discussed in first patch set, android doesn't support exception
> handling. This
where is this in your commit log?
> is the reason powertop had DISABLE_TRYCATCH conditional macro which is
> removed in recent commit.
Android being braindead about the C++ language should be it's own patch, not snuck in as part of another change.
>
> The patch 2/2 adds stubs for exception handling
>
> #define try if (true)
> #define catch(x) if (false)
>
> With this, fprintf(stderr, "%s\n", c.what()); in catch block throws
> undefined reference
> to c. So added message instead of c.what().
>
> Any better ways of adding stubs are welcome.
#define try(x) if (true) { x;
#define catch(x) } else
?
next reply other threads:[~2012-09-25 5:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 5:45 Arjan van de Ven [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-09-25 15:25 [Powertop] [PATCH v2 1/2] Updates to support Android platform Chris Ferron
2012-09-25 6:11 Arjan van de Ven
2012-09-25 5:34 Rajagopal Venkat
2012-09-24 15:57 Chris Ferron
2012-09-24 13:28 Rajagopal Venkat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506144F4.70007@linux.intel.com \
--to=powertop@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.