From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Fioravante Subject: Re: PATCH [base vtpm and libxl patches 4/6] add iomem support to libxl Date: Tue, 25 Sep 2012 12:57:55 -0400 Message-ID: <5061E293.7000106@jhuapl.edu> References: <505CBA02.5040308@jhuapl.edu> <1348569044.3452.176.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3628728076835693966==" Return-path: In-Reply-To: <1348569044.3452.176.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org This is a cryptographically signed message in MIME format. --===============3628728076835693966== Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha1; boundary="------------ms070705040602070303010407" This is a cryptographically signed message in MIME format. --------------ms070705040602070303010407 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/25/2012 06:30 AM, Ian Campbell wrote: > On Fri, 2012-09-21 at 20:03 +0100, Matthew Fioravante wrote: > >> + if ( ret<0 ){ > Tiny coding style nit, this should be > if (ret < 0) {=20 Will fix >> + LOGE(ERROR, >> + "failed give dom%d access to iomem range >> %"PRIx64"-%"PRIx64, >> + domid, io->start, io->start + io->number - 1); >> + ret =3D ERROR_FAIL; >> + } >> + } >> + >> + >> + >> for (i =3D 0; i < d_config->num_nics; i++) { >> /* We have to init the nic here, because we still haven't >> * called libxl_device_nic_add at this point, but qemu needs >> @@ -1005,6 +1005,30 @@ static void parse_config_data(const char >> *config_source, >> } >> } >> =20 >> + if (!xlu_cfg_get_list(config, "iomem", &iomem, &num_iomem, 0)) { >> + b_info->num_iomem =3D num_iomem; >> + b_info->iomem =3D calloc(num_iomem, sizeof(*b_info->iomem)); >> + if (b_info->iomem =3D=3D NULL) { >> + fprintf(stderr, "unable to allocate memory for iomem\n");= >> + exit(-1); >> + } >> + for (i =3D 0; i < num_iomem; i++) { >> + buf =3D xlu_cfg_get_listitem (iomem, i); >> + if (!buf) { >> + fprintf(stderr, >> + "xl: Unable to get element %d in iomem list\n= ", i); >> + exit(1); >> + } >> + if(sscanf(buf, "%" SCNx64",%" SCNu64, >> &b_info->iomem[i].start, &b_info->iomem[i].number) !=3D 2) { > This should be relatively simply to parse with strtoul (see the ioports= > case) which would allow people to select hex or decimal in their > configuration files. Do we want to support hex or decimal? Pretty much anytime people start talking about physical memory addresses or page numbers they use hex. Also the ioports code actually only supports hexadecimal as it sets the base in strtoul to 16. It also explicitly says in the xl.cfg manpage that ioports should be given in hex. > > Ian > --------------ms070705040602070303010407 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIDyjCC A8YwggMvoAMCAQICBD/xyf0wDQYJKoZIhvcNAQEFBQAwLzELMAkGA1UEBhMCVVMxDzANBgNV BAoTBkpIVUFQTDEPMA0GA1UECxMGQklTRENBMB4XDTEwMDYxMTE4MjIwNloXDTEzMDYxMTE4 NTIwNlowZjELMAkGA1UEBhMCVVMxDzANBgNVBAoTBkpIVUFQTDEPMA0GA1UECxMGUGVvcGxl MTUwFgYDVQQLEw9WUE5Hcm91cC1CSVNEQ0EwGwYDVQQDExRNYXR0aGV3IEUgRmlvcmF2YW50 ZTCBnzANBgkqhkiG9w0BAQEFAAOBjQAwgYkCgYEAnpbwVSP6o1Nb5lcW7dd3yTo9iBJdi7qz 4nANOMFPK7JOy5npKN1iiousl28U/scUJES55gPwAWYJK3uVyQAsA4adgDKi5DoD1UHDQEwp bY7iHLJeq0NPr4BqYNqnCFPbE6HC8zSJrr4qKn+gVUQT39SIFqdiIPJwZL8FYTRQ/zsCAwEA AaOCAbYwggGyMAsGA1UdDwQEAwIHgDArBgNVHRAEJDAigA8yMDEwMDYxMTE4MjIwNlqBDzIw MTIwNzE3MjI1MjA2WjAbBg0rBgEEAbMlCwMBAQEBBAoWCGZpb3JhbWUxMBsGDSsGAQQBsyUL AwEBAQIEChIIMDAxMDQyNjEwWAYJYIZIAYb6ax4BBEsMSVRoZSBwcml2YXRlIGtleSBjb3Jy ZXNwb25kaW5nIHRvIHRoaXMgY2VydGlmaWNhdGUgbWF5IGhhdmUgYmVlbiBleHBvcnRlZC4w KAYDVR0RBCEwH4EdTWF0dGhldy5GaW9yYXZhbnRlQGpodWFwbC5lZHUwUgYDVR0fBEswSTBH oEWgQ6RBMD8xCzAJBgNVBAYTAlVTMQ8wDQYDVQQKEwZKSFVBUEwxDzANBgNVBAsTBkJJU0RD QTEOMAwGA1UEAxMFQ1JMNTYwHwYDVR0jBBgwFoAUCDUpmxH52EU2CyWmF2EJMB1yqeswHQYD VR0OBBYEFO6LYxg6r9wHZ+zdQtBHn1dZ/YTNMAkGA1UdEwQCMAAwGQYJKoZIhvZ9B0EABAww ChsEVjcuMQMCBLAwDQYJKoZIhvcNAQEFBQADgYEAJO9HQh4YNChVLzuZqK5ARJARD8JoujGZ fdo75quvg2jXFQe2sEjvLnxJZgm/pv8fdZakq48CWwjYHKuvIp7sDjTEsQfo+y7SpN/N2NvJ WU5SqfK1VgYtNLRRoGJUB5Q1aZ+Dg95g3kqpyfpUMISJL8IKVLtJVfN4fggFVUYZ9wwxggGr MIIBpwIBATA3MC8xCzAJBgNVBAYTAlVTMQ8wDQYDVQQKEwZKSFVBUEwxDzANBgNVBAsTBkJJ U0RDQQIEP/HJ/TAJBgUrDgMCGgUAoIHLMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJ KoZIhvcNAQkFMQ8XDTEyMDkyNTE2NTc1NVowIwYJKoZIhvcNAQkEMRYEFGRjqLrt7wxuetNe Odrl331/YvQ3MGwGCSqGSIb3DQEJDzFfMF0wCwYJYIZIAWUDBAEqMAsGCWCGSAFlAwQBAjAK BggqhkiG9w0DBzAOBggqhkiG9w0DAgICAIAwDQYIKoZIhvcNAwICAUAwBwYFKw4DAgcwDQYI KoZIhvcNAwICASgwDQYJKoZIhvcNAQEBBQAEgYANIZY+JGO+5wIuaFLz6k1EzjYMiLaKaR43 SZFJNwIQGHmVfD7firrj5rZ+35ohY12bZtcp8ZXzLEC8KF9+/9kpFipk25atc3PWWJPEds34 Dqk6S8FXil5BFMWz/tkz1julSP9fHjFbm0sPGjqTPQmHhRzYhjVx2+O2GnL6dQDLRgAAAAAA AA== --------------ms070705040602070303010407-- --===============3628728076835693966== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============3628728076835693966==--