From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGfKY-0006JX-8y for qemu-devel@nongnu.org; Tue, 25 Sep 2012 20:18:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TGfKX-0001xh-6C for qemu-devel@nongnu.org; Tue, 25 Sep 2012 20:18:22 -0400 Received: from mout.web.de ([212.227.17.11]:55095) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGfKW-0001xT-T1 for qemu-devel@nongnu.org; Tue, 25 Sep 2012 20:18:21 -0400 Message-ID: <506249C4.3030900@web.de> Date: Wed, 26 Sep 2012 02:18:12 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1348486090-21177-1-git-send-email-kraxel@redhat.com> <873925sm6e.fsf@codemonkey.ws> In-Reply-To: <873925sm6e.fsf@codemonkey.ws> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigF508751E85DC81E16BEA407C" Subject: Re: [Qemu-devel] [PATCH 0/2] add pci-serial device. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Gerd Hoffmann , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigF508751E85DC81E16BEA407C Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2012-09-26 01:43, Anthony Liguori wrote: > Gerd Hoffmann writes: >=20 >> Hi, >> >> Two patches, first split up serial.c a bit, >> then actually add the pci-based serial device. >=20 > The series looks good to me. A couple requests: >=20 > 1) Could you add a spec describing this new PCI device? Doesn't need t= o > be more than a couple paragraphs since the device is super simple. >=20 > 2) Could you make the inf file an separate patch and either include > documentation in the commit message on how to use it with Windows or= > just add a comment to the inf file? >=20 > This is a new PCI space for QEMU too. Is this a driver that is "owned"= > by QEMU and Red Hat is donating the PCI id or is this a driver that RH > controls that we're implementing? >=20 > The only reason I ask is whether this is something we can add new > features to. I can't think of one off hand, but it can't hurt to work > this out up front. Multiport e.g. (to save PCI slots). There was some proposal recently to add a model of an real multiport PCI card, just don't find the mail right now... Jan --------------enigF508751E85DC81E16BEA407C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iEYEARECAAYFAlBiSckACgkQitSsb3rl5xQyfACfWOIcG8mHhAutsSI8K+sL9UiA P1sAoLuVe3JyAQqgLTEdOj1qSJOfIq7/ =gxTm -----END PGP SIGNATURE----- --------------enigF508751E85DC81E16BEA407C--