From: Suresh Jayaraman <sjayaraman-IBi9RG/b67k@public.gmane.org>
To: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] cifs: change DOS/NT/POSIX mapping of ERRnoresource
Date: Wed, 26 Sep 2012 10:38:58 +0530 [thread overview]
Message-ID: <50628DEA.4040802@suse.com> (raw)
In-Reply-To: <1348493620-1887-1-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On 09/24/2012 07:03 PM, Jeff Layton wrote:
> ERRnoresource is an ERRSRV level (aka server-side) error and means "No
> resources currently available for request". Currently that maps to POSIX
> -ENOBUFS. No NT errors map to it currently.
>
> NT_STATUS_INSUFFICIENT_RESOURCES and NT_STATUS_INSUFF_SERVER_RESOURCES
> are also similar in meaning. Currently the client maps those to
> ERRnomem, which maps to -ENOMEM in POSIX.
>
> All of these mappings seem to be quite wrong to me and are confusing for
> users. All of the above errors indicate problems on the server, not the
> client. Reporting -ENOMEM or -ENOBUFS implies that the client is running
> out of resources.
>
> This patch changes those mappings. The NT_* errors are changed to map to
> the SRV level ERRnoresource. That error is in turn changed to return
> -EREMOTEIO which is the only POSIX error I could find that conveys that
> something went wrong on the server. While we're at it, change the SMB2
> equivalent error to return the same.
>
> Signed-off-by: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
Seems reasonable to me.
Acked-by: Suresh Jayaraman <sjayaraman-IBi9RG/b67k@public.gmane.org>
prev parent reply other threads:[~2012-09-26 5:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 13:33 [PATCH] cifs: change DOS/NT/POSIX mapping of ERRnoresource Jeff Layton
[not found] ` <1348493620-1887-1-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-09-26 5:08 ` Suresh Jayaraman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50628DEA.4040802@suse.com \
--to=sjayaraman-ibi9rg/b67k@public.gmane.org \
--cc=jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.