From: Gerd Hoffmann <kraxel@redhat.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [usb:usb-next 66/70] drivers/usb/storage/uas.c:638:12: sparse: context imbalance in 'uas_eh_task
Date: Wed, 26 Sep 2012 06:20:19 +0000 [thread overview]
Message-ID: <50629EA3.80307@redhat.com> (raw)
In-Reply-To: <20120926030632.GD13486@localhost>
On 09/26/12 05:06, Fengguang Wu wrote:
> Hi Gerd,
>
> FYI, there are new sparse warnings show up in
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next
> head: 655db7980596f0ad4f15f8f4c51beb3e705762de
> commit: e064852072c47b69f62325c6b7fa4a58332655bd [66/70] USB: uas: add locking
>
> + drivers/usb/storage/uas.c:638:12: sparse: context imbalance in 'uas_eh_task_mgmt' - wrong count at exit
Ok, that one is real, we don't unlock in the error paths, I'll send a
incremental fix in a moment.
> drivers/usb/storage/uas.c: In function 'uas_stat_cmplt':
> drivers/usb/storage/uas.c:280:15: warning: 'cmdinfo' may be used uninitialized in this function [-Wmaybe-uninitialized]
Wrong, can't happen, although that one is hard to see for gcc. I'll see
what I can do about it.
cheers,
Gerd
prev parent reply other threads:[~2012-09-26 6:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 3:06 [usb:usb-next 66/70] drivers/usb/storage/uas.c:638:12: sparse: context imbalance in 'uas_eh_task_mgm Fengguang Wu
2012-09-26 6:20 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50629EA3.80307@redhat.com \
--to=kraxel@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.