* [PATCH] drm/nouveau/i2c: correct default settings for i2c ports
@ 2012-09-22 17:33 Dmitry Eremin-Solenikov
[not found] ` <1348335230-20502-1-git-send-email-dmitry_eremin-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Eremin-Solenikov @ 2012-09-22 17:33 UTC (permalink / raw)
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Fix typo introduced when converting to core infrastructure.
Signed-off-by: Dmitry Eremin-Solenikov <dmitry_eremin-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
---
drivers/gpu/drm/nouveau/core/subdev/bios/i2c.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/core/subdev/bios/i2c.c b/drivers/gpu/drm/nouveau/core/subdev/bios/i2c.c
index 5fcce5d..ad577db 100644
--- a/drivers/gpu/drm/nouveau/core/subdev/bios/i2c.c
+++ b/drivers/gpu/drm/nouveau/core/subdev/bios/i2c.c
@@ -112,13 +112,13 @@ dcb_i2c_parse(struct nouveau_bios *bios, u8 idx, struct dcb_i2c_entry *info)
info->drive = nv_ro08(bios, ent + 4);
if (!info->drive) info->drive = 0x3f;
info->sense = nv_ro08(bios, ent + 5);
- if (!info->sense) info->drive = 0x3e;
+ if (!info->sense) info->sense = 0x3e;
} else
if (idx == 1) {
info->drive = nv_ro08(bios, ent + 6);
if (!info->drive) info->drive = 0x37;
info->sense = nv_ro08(bios, ent + 7);
- if (!info->sense) info->drive = 0x36;
+ if (!info->sense) info->sense = 0x36;
}
info->type = DCB_I2C_NV04_BIT;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/nouveau/i2c: correct default settings for i2c ports
[not found] ` <1348335230-20502-1-git-send-email-dmitry_eremin-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
@ 2012-09-26 1:06 ` Ben Skeggs
[not found] ` <20120926010654.GA17068-6RkuLLNOGXsZ315U/fw+0NvLeJWuRmrY@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Ben Skeggs @ 2012-09-26 1:06 UTC (permalink / raw)
To: Dmitry Eremin-Solenikov; +Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
On Sat, Sep 22, 2012 at 09:33:50PM +0400, Dmitry Eremin-Solenikov wrote:
> Fix typo introduced when converting to core infrastructure.
>
> Signed-off-by: Dmitry Eremin-Solenikov <dmitry_eremin-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
Thanks, pushed! I'll likely squash this into the offending commit and
note your corrections in the commit log.
Ben.
> ---
> drivers/gpu/drm/nouveau/core/subdev/bios/i2c.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/core/subdev/bios/i2c.c b/drivers/gpu/drm/nouveau/core/subdev/bios/i2c.c
> index 5fcce5d..ad577db 100644
> --- a/drivers/gpu/drm/nouveau/core/subdev/bios/i2c.c
> +++ b/drivers/gpu/drm/nouveau/core/subdev/bios/i2c.c
> @@ -112,13 +112,13 @@ dcb_i2c_parse(struct nouveau_bios *bios, u8 idx, struct dcb_i2c_entry *info)
> info->drive = nv_ro08(bios, ent + 4);
> if (!info->drive) info->drive = 0x3f;
> info->sense = nv_ro08(bios, ent + 5);
> - if (!info->sense) info->drive = 0x3e;
> + if (!info->sense) info->sense = 0x3e;
> } else
> if (idx == 1) {
> info->drive = nv_ro08(bios, ent + 6);
> if (!info->drive) info->drive = 0x37;
> info->sense = nv_ro08(bios, ent + 7);
> - if (!info->sense) info->drive = 0x36;
> + if (!info->sense) info->sense = 0x36;
> }
>
> info->type = DCB_I2C_NV04_BIT;
> --
> 1.7.10.4
>
> _______________________________________________
> Nouveau mailing list
> Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
> http://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/nouveau/i2c: correct default settings for i2c ports
[not found] ` <20120926010654.GA17068-6RkuLLNOGXsZ315U/fw+0NvLeJWuRmrY@public.gmane.org>
@ 2012-09-26 6:32 ` Dmitry Eremin-Solenikov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Eremin-Solenikov @ 2012-09-26 6:32 UTC (permalink / raw)
To: Ben Skeggs; +Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
On 09/26/2012 05:06 AM, Ben Skeggs wrote:
> On Sat, Sep 22, 2012 at 09:33:50PM +0400, Dmitry Eremin-Solenikov wrote:
>> Fix typo introduced when converting to core infrastructure.
>>
>> Signed-off-by: Dmitry Eremin-Solenikov<dmitry_eremin-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
> Thanks, pushed! I'll likely squash this into the offending commit and
> note your corrections in the commit log.
Fine for me, thank you!
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-26 6:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-22 17:33 [PATCH] drm/nouveau/i2c: correct default settings for i2c ports Dmitry Eremin-Solenikov
[not found] ` <1348335230-20502-1-git-send-email-dmitry_eremin-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
2012-09-26 1:06 ` Ben Skeggs
[not found] ` <20120926010654.GA17068-6RkuLLNOGXsZ315U/fw+0NvLeJWuRmrY@public.gmane.org>
2012-09-26 6:32 ` Dmitry Eremin-Solenikov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.