All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gao feng <gaofeng@cn.fujitsu.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: davem@davemloft.net, netfilter-devel@vger.kernel.org,
	linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
	pablo@netfilter.org, steffen.klassert@secunet.com,
	linux-crypto@vger.kernel.org, jengelh@inai.de,
	stephen.hemminger@vyatta.com
Subject: Re: [PATCH 01/11] netlink: add reference of module in netlink_dump_start
Date: Wed, 26 Sep 2012 15:24:03 +0800	[thread overview]
Message-ID: <5062AD93.9080206@cn.fujitsu.com> (raw)
In-Reply-To: <1348643247.5093.32.camel@edumazet-glaptop>

于 2012年09月26日 15:07, Eric Dumazet 写道:
> On Wed, 2012-09-26 at 12:52 +0800, Gao feng wrote:
> 
>> +int netlink_dump_done(struct netlink_callback *cb)
>> +{
>> +	if (cb->module)
>> +		module_put(cb->module);
>> +	return 0;
>> +}
>> +EXPORT_SYMBOL(netlink_dump_done);
>> +
> 
> No need to test cb->module being not NULL
> 
> 
> int netlink_dump_done(struct netlink_callback *cb)
> {
> 	module_put(cb->module);
> 	return 0;
> }
> 
> Same remark for try_module_get() call
> 

will fix it in v2 patchset.

thanks Eric.

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2012-09-26  7:24 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-26  4:52 [PATCH 01/11] netlink: add reference of module in netlink_dump_start Gao feng
2012-09-26  4:52 ` [PATCH 02/11] inet_diag: pass inet_diag module to netlink_dump_start Gao feng
2012-09-26 16:07   ` Stephen Hemminger
     [not found]     ` <20120926090714.618a4b39-We1ePj4FEcvRI77zikRAJc56i+j3xesD0e7PPNI6Mm0@public.gmane.org>
2012-09-26 17:26       ` Pablo Neira Ayuso
2012-09-26  4:52 ` [PATCH 03/11] unix_diag: pass unix_diag " Gao feng
2012-09-26  4:52 ` [PATCH 04/11] nf_conntrack_netlink: pass nf_conntrack_netlink " Gao feng
2012-09-26  4:52 ` [PATCH 05/11] nfnetlink_acct: pass nfnetlink_acct " Gao feng
2012-09-26  4:52 ` [PATCH 06/11] nfnetlink_cthelper: pass nfnetlink_cthelper " Gao feng
2012-09-26  4:52 ` [PATCH 07/11] nfnetlink_cttimeout: pass nfnetlink_cttimeout " Gao feng
2012-09-26  4:52 ` [PATCH 08/11] crypto: pass crypto_user " Gao feng
     [not found]   ` <1348635140-20225-8-git-send-email-gaofeng-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2012-09-26  5:49     ` Steffen Klassert
2012-09-26  7:21       ` Gao feng
2012-09-26  4:52 ` [PATCH 09/11] xfrm: pass xfrm_user " Gao feng
     [not found] ` <1348635140-20225-1-git-send-email-gaofeng-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2012-09-26  4:52   ` [PATCH 10/11] ipset: pass ipset " Gao feng
2012-09-26  7:07   ` [PATCH 01/11] netlink: add reference of module in netlink_dump_start Eric Dumazet
2012-09-26  7:24     ` Gao feng [this message]
2012-09-26  4:52 ` [PATCH 11/11] infiniband: pass rdma_cm module to netlink_dump_start Gao feng
2012-09-26  5:41 ` [PATCH 01/11] netlink: add reference of module in netlink_dump_start Steffen Klassert
     [not found]   ` <20120926054102.GD4221-opNxpl+3fjRBDgjK7y7TUQ@public.gmane.org>
2012-09-26  6:05     ` Gao feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5062AD93.9080206@cn.fujitsu.com \
    --to=gaofeng@cn.fujitsu.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=jengelh@inai.de \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=steffen.klassert@secunet.com \
    --cc=stephen.hemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.