From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Tomasz Stanislawski <t.stanislaws@samsung.com>,
linux-media@vger.kernel.org, patches@linaro.org
Subject: Re: [PATCH] [media] s5p-tv: Fix potential NULL pointer dereference error
Date: Wed, 26 Sep 2012 10:50:33 +0200 [thread overview]
Message-ID: <5062C1D9.2090104@samsung.com> (raw)
In-Reply-To: <50601F32.5080700@samsung.com>
On 09/24/2012 10:52 AM, Tomasz Stanislawski wrote:
> On 09/22/2012 09:39 AM, Sachin Kamat wrote:
>> When mdev is NULL, the error print statement will try to dereference
>> the NULL pointer.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> ---
>> drivers/media/platform/s5p-tv/mixer_drv.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/media/platform/s5p-tv/mixer_drv.c b/drivers/media/platform/s5p-tv/mixer_drv.c
>> index a15ca05..ca0f297 100644
>> --- a/drivers/media/platform/s5p-tv/mixer_drv.c
>> +++ b/drivers/media/platform/s5p-tv/mixer_drv.c
>> @@ -384,7 +384,7 @@ static int __devinit mxr_probe(struct platform_device *pdev)
>>
>> mdev = kzalloc(sizeof *mdev, GFP_KERNEL);
>> if (!mdev) {
>> - mxr_err(mdev, "not enough memory.\n");
>> + dev_err(dev, "not enough memory.\n");
>> ret = -ENOMEM;
>> goto fail;
>> }
>>
>
> Acked-by: Tomasz Stanislawski <t.stanislaws@samsung.com>
Applied, thanks!
Regards,
Sylwester
prev parent reply other threads:[~2012-09-26 8:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-22 7:39 [PATCH] [media] s5p-tv: Fix potential NULL pointer dereference error Sachin Kamat
2012-09-24 8:52 ` Tomasz Stanislawski
2012-09-26 8:50 ` Sylwester Nawrocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5062C1D9.2090104@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=patches@linaro.org \
--cc=sachin.kamat@linaro.org \
--cc=t.stanislaws@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.