From: Chris Ferron <chris.e.ferron at linux.intel.com>
To: powertop@lists.01.org
Subject: Re: [Powertop] [PATCH v2] Fix string null termination and SIGABRT from glibc
Date: Wed, 26 Sep 2012 10:13:45 -0700 [thread overview]
Message-ID: <506337C9.1090807@linux.intel.com> (raw)
In-Reply-To: 20120926141939.GB3014@swordfish
[-- Attachment #1: Type: text/plain, Size: 1541 bytes --]
On 09/26/2012 07:19 AM, Sergey Senozhatsky wrote:
> On (09/26/12 16:12), Mikko Rapeli wrote:
>> According to http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=682388
>> the string is not null terminated when too much data is read.
>>
>> This patch fixes the crashes on my system.
>> ---
>> src/process/process.cpp | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
> LGTM, thanks!
>
> -ss
>
Your patch has been merged.
Thank You
-C
>> diff --git a/src/process/process.cpp b/src/process/process.cpp
>> index 71f81b6..34dc68d 100644
>> --- a/src/process/process.cpp
>> +++ b/src/process/process.cpp
>> @@ -86,7 +86,7 @@ static void cmdline_to_string(char *str)
>>
>> process::process(const char *_comm, int _pid, int _tid) : power_consumer()
>> {
>> - char line[4096];
>> + char line[4097];
>> ifstream file;
>>
>> strcpy(comm, _comm);
>> @@ -103,6 +103,7 @@ process::process(const char *_comm, int _pid, int _tid) : power_consumer()
>> file.open(line);
>> while (file) {
>> file.getline(line, 4096);
>> + line[4096] = '\0';
>> if (strstr(line, "Tgid")) {
>> char *c;
>> c = strchr(line, ':');
>> --
>> 1.7.10.4
>>
>> _______________________________________________
>> PowerTop mailing list
>> PowerTop(a)lists.01.org
>> https://lists.01.org/mailman/listinfo/powertop
>>
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop
next reply other threads:[~2012-09-26 17:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 17:13 Chris Ferron [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-09-26 14:19 [Powertop] [PATCH v2] Fix string null termination and SIGABRT from glibc Sergey Senozhatsky
2012-09-26 14:12 Mikko Rapeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506337C9.1090807@linux.intel.com \
--to=powertop@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.