From: Goffredo Baroncelli <kreijack@libero.it>
To: kreijack@inwind.it
Cc: zwu.kernel@gmail.com, linux-btrfs@vger.kernel.org,
linux-kernel@vger.kernel.org, jbacik@fusionio.com, dave@jikos.cz,
linuxram@linux.vnet.ibm.com,
Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
Subject: Re: [PATCH v2 2/2] btrfs-progs: Fix up memory leakage
Date: Wed, 26 Sep 2012 23:13:20 +0200 [thread overview]
Message-ID: <50636FF0.6010701@libero.it> (raw)
In-Reply-To: <5061E676.8080203@libero.it>
On 09/25/2012 07:14 PM, Goffredo Baroncelli wrote:
> I strongly disagree with this approach. The callee often don't know what
> happen after and before the call. The same is true for the programmer,
> because the code is quite often updated by several people. A clean
> exit() is the right thing to do as general rule.
My fingers were faster than my brain :-)
s/clean exit()/clean-up/
next prev parent reply other threads:[~2012-09-26 21:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 2:02 [resend][PATCH v2 0/2] btrfs-progs: some bugfixes zwu.kernel
2012-09-25 2:02 ` [PATCH v2 1/2] btrfs-progs: Close file descriptor on exit zwu.kernel
2012-09-25 10:12 ` David Sterba
2012-09-25 13:58 ` Zhi Yong Wu
2012-09-25 2:02 ` [PATCH v2 2/2] btrfs-progs: Fix up memory leakage zwu.kernel
2012-09-25 10:14 ` David Sterba
2012-09-25 14:03 ` Zhi Yong Wu
2012-09-25 17:14 ` Goffredo Baroncelli
2012-09-26 2:58 ` Zhi Yong Wu
2012-09-26 21:13 ` Goffredo Baroncelli [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-09-05 9:21 [PATCH v2 0/2] btrfs-progs: some bugfixes Zhi Yong Wu
2012-09-05 9:21 ` [PATCH v2 2/2] btrfs-progs: Fix up memory leakage Zhi Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50636FF0.6010701@libero.it \
--to=kreijack@libero.it \
--cc=dave@jikos.cz \
--cc=jbacik@fusionio.com \
--cc=kreijack@inwind.it \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxram@linux.vnet.ibm.com \
--cc=wuzhy@linux.vnet.ibm.com \
--cc=zwu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.