From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TH1XZ-0001Sl-BW for qemu-devel@nongnu.org; Wed, 26 Sep 2012 20:01:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TH1XX-00040S-Dq for qemu-devel@nongnu.org; Wed, 26 Sep 2012 20:01:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61313) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TH1XX-00040C-5N for qemu-devel@nongnu.org; Wed, 26 Sep 2012 20:01:15 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8R01DC0029897 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 26 Sep 2012 20:01:13 -0400 Message-ID: <50639746.6000205@redhat.com> Date: Wed, 26 Sep 2012 18:01:10 -0600 From: Eric Blake MIME-Version: 1.0 References: <1348675011-8794-1-git-send-email-pbonzini@redhat.com> <1348675011-8794-26-git-send-email-pbonzini@redhat.com> In-Reply-To: <1348675011-8794-26-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigF3E31BDBB15A823078B17F0B" Subject: Re: [Qemu-devel] [PATCH v2 25/45] block: introduce BLOCK_JOB_READY event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigF3E31BDBB15A823078B17F0B Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/26/2012 09:56 AM, Paolo Bonzini wrote: > Even for jobs that need to be manually completed, management may want > to take care itself of the completion, not requiring the user to issue > a command to terminate the job. In this case we want to avoid that > they poll us continuously, waiting for completion to become available. > Thus, add a new event that signals the phase switch and the availabilit= y > of the block-job-complete command. >=20 > Signed-off-by: Paolo Bonzini > --- > =20 > +BLOCK_JOB_READY > +--------------- > + > +Emitted when a block job is ready to complete. > + > +Data: > + > +- "device": device name (json-string) > + > +Example: > + > +{ "event": "BLOCK_JOB_READY", > + "data": { "device": "ide0-hd1", > + "operation": "write", > + "action": "stop" }, You didn't document operation and action; are you missing documentation for this event, or are they bad copy-and-paste in the example? Again, libvirt would really like to have 'type':'mirror' in the data, for symmetry with all the other BLOCK_JOB_* events. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigF3E31BDBB15A823078B17F0B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQY5dHAAoJEKeha0olJ0Nqbc8H/Rat6lXXh4WvHghcc/tfyQrp M3W4F5vVqxj9rJfnOztcp/LMsfHcL5V6ocB+zoTlHERlAhbM7XOyHuVVrmHh9z7H JL2+gyIrSqLuQY/PYLMsOAJlsNo26WUajRjUjIw/j50xgvZVDjwbObrPsUGXJhLh hvs4FkkT3CqfB50480xVC2h5kZvzoqQvUy3r1O4iNJ3T5SL5x1UKB76Tnoap7pNd As9M17hms7AMX9wOCH63fTSbBAYaPIvn0alT0/kzseAPmOgqpMfJ+OqkEIl3upaA aw9q+IT393kdJRp76EYFGpQSQxgKkYi9M1fBTzsnMOeR61Oaj7QFRZ2ATthRjSc= =oBLd -----END PGP SIGNATURE----- --------------enigF3E31BDBB15A823078B17F0B--