Re: [PATCH] mlx4_core: Fix crash on uninitialized priv->cmd.slave_sem

[Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>]

On 27/09/2012 10:17, Roland Dreier wrote:
> I think I had it cabled up directly to another HCA, and that HCA was in a
> system that was either off or at least didn't have the driver loaded.  So the
> port was in the physically DOWN state...
>
> However, I just tried it and even with that other HCA enabled (and running
> opensm), I still see
>
>      mlx4_core 0000:05:00.0: Unknown command:0x4d accepted from slave:0
>      mlx4_core 0000:05:00.0: Sense command failed for port: 1
>
> before init_hca finishes, so I think I would have crashed without my patch
> still.  Not sure I understand how you guys miss hitting this fatal call to
> SENSE_PORT during init (or what the intention for SENSE_PORT is
> since right now in SR-IOV mode it always fails due to no wrapper).
>
> I'm not doing anything funny with the port type, I have a one-port CX3
> running FW built with the exact default .ini file, except for enabling SR-IOV.
> And the only mlx4_core module parameter I'm passing in is "num_vfs=1".
>

Thanks for the further details, sounds like something/s is indeed broken 
here, in the code and/or
in the regression testing of it. We'll do our best to provide deeper 
reasoning of what's going on today,
and if not, by Tuesday when Jack is back. This way (your patch) or 
another (some other direction suggested
by the team or Jack) seems we're safe for the merge window.

Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html