Re: [PATCH] perf probe: print an enum type variable in "enum variable-name" format when showing accessible variables

[Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>]

(2012/09/27 11:36), Hyeoncheol Lee wrote:
> When showing accessible variables, an enum type variable was
>  printed in "variable-name" format. Change this format into
> "enum variable-name".

Right, and even if the enum has a type name, it shows
only "type-name variable-name", this should show
"enum type-name variable-name".

Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>

Thank you!

> 
> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> Signed-off-by: Hyeoncheol Lee <hyc.lee@gmail.com>
> ---
>  tools/perf/util/dwarf-aux.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/perf/util/dwarf-aux.c b/tools/perf/util/dwarf-aux.c
> index ee51e9b..3e5f543 100644
> --- a/tools/perf/util/dwarf-aux.c
> +++ b/tools/perf/util/dwarf-aux.c
> @@ -804,6 +804,8 @@ int die_get_typename(Dwarf_Die *vr_die, char *buf, int len)
>  			tmp = "union ";
>  		else if (tag == DW_TAG_structure_type)
>  			tmp = "struct ";
> +		else if (tag == DW_TAG_enumeration_type)
> +			tmp = "enum ";
>  		/* Write a base name */
>  		ret = snprintf(buf, len, "%s%s", tmp, dwarf_diename(&type));
>  		return (ret >= len) ? -E2BIG : ret;
> 


-- 
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com