From: Paolo Bonzini <pbonzini@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Asias He <asias@redhat.com>,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
"Michael S. Tsirkin" <mst@redhat.com>,
Stefan Hajnoczi <stefanha@gmail.com>
Subject: Re: [PATCH] virtio-blk: Disable callback in virtblk_done()
Date: Thu, 27 Sep 2012 12:01:36 +0200 [thread overview]
Message-ID: <50642400.5030906@redhat.com> (raw)
In-Reply-To: <87ehlo497o.fsf@rustcorp.com.au>
Il 27/09/2012 02:10, Rusty Russell ha scritto:
>>> >> + do {
>>> >> + virtqueue_disable_cb(vq);
>>> >> + while ((vbr = virtqueue_get_buf(vblk->vq, &len)) != NULL) {
>>> >> + if (vbr->bio) {
>>> >> + virtblk_bio_done(vbr);
>>> >> + bio_done = true;
>>> >> + } else {
>>> >> + virtblk_request_done(vbr);
>>> >> + req_done = true;
>>> >> + }
>>> >> }
>>> >> - }
>>> >> + } while (!virtqueue_enable_cb(vq));
>>> >> /* In case queue is stopped waiting for more buffers. */
>>> >> if (req_done)
>>> >> blk_start_queue(vblk->disk->queue);
> Fascinating. Please just confirm that VIRTIO_RING_F_EVENT_IDX is
> enabled?
Yeah, it's a nice and cheap trick. Stefan, I see that you had this in
virtio-scsi since even before I picked it up. Do you remember how you
came up with it?
Paolo
next prev parent reply other threads:[~2012-09-27 10:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 2:36 [PATCH] virtio-blk: Disable callback in virtblk_done() Asias He
2012-09-25 14:08 ` Asias He
2012-09-27 0:10 ` Rusty Russell
2012-09-27 6:48 ` Asias He
2012-09-28 6:08 ` Rusty Russell
2012-09-28 7:03 ` Asias He
2012-09-27 10:01 ` Paolo Bonzini
2012-09-27 10:01 ` Paolo Bonzini [this message]
2012-10-02 14:42 ` Stefan Hajnoczi
2012-09-28 8:32 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50642400.5030906@redhat.com \
--to=pbonzini@redhat.com \
--cc=asias@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=stefanha@gmail.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.