From: Paolo Bonzini <pbonzini@redhat.com>
To: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, lcapitulino@redhat.com, qemu-devel@nongnu.org,
armbru@redhat.com
Subject: Re: [Qemu-devel] [RFC v2 6/7] create new function: qemu_opt_set_number
Date: Thu, 27 Sep 2012 13:56:17 +0200 [thread overview]
Message-ID: <50643EE1.1000509@redhat.com> (raw)
In-Reply-To: <1348722865-20564-7-git-send-email-wdongxu@linux.vnet.ibm.com>
Il 27/09/2012 07:14, Dong Xu Wang ha scritto:
> +int qemu_opt_set_number(QemuOpts *opts, const char *name, int64_t val)
> +{
> + char buffer[1024];
> + snprintf(buffer, sizeof(buffer), "%" PRId64, val);
> + return qemu_opt_set(opts, name, buffer);
> +}
This has the same problem as qemu_opt_set_bool after patch 1.
Paolo
next prev parent reply other threads:[~2012-09-27 11:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 5:14 [Qemu-devel] [RFC v2 0/7] replace QEMUOptionParameter with QemuOpts parser Dong Xu Wang
2012-09-27 5:14 ` [Qemu-devel] [RFC v2 1/7] qemu-option: qemu_opt_set_bool(): fix code duplication Dong Xu Wang
2012-09-27 11:55 ` Paolo Bonzini
2012-09-27 5:14 ` [Qemu-devel] [RFC v2 2/7] qemu-option: opt_set(): split it up into more functions Dong Xu Wang
2012-09-27 5:14 ` [Qemu-devel] [RFC v2 3/7] qemu-option: qemu_opts_validate(): fix duplicated code Dong Xu Wang
2012-09-27 5:14 ` [Qemu-devel] [RFC v2 4/7] introduce qemu_opts_create_nofail function Dong Xu Wang
2012-09-27 5:14 ` [Qemu-devel] [RFC v2 5/7] use qemu_opts_create_nofail Dong Xu Wang
2012-09-27 5:14 ` [Qemu-devel] [RFC v2 6/7] create new function: qemu_opt_set_number Dong Xu Wang
2012-09-27 11:56 ` Paolo Bonzini [this message]
2012-09-27 5:14 ` [Qemu-devel] [RFC v2 7/7] remove QEMUOptionParameter Dong Xu Wang
2012-09-27 12:03 ` Paolo Bonzini
2012-09-28 6:42 ` Dong Xu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50643EE1.1000509@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wdongxu@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.