From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vijay Purushothaman Subject: Re: [PATCH 8/9] drm/i915: Reverse min, max vco limits for VLV HDMI Date: Thu, 27 Sep 2012 19:02:51 +0530 Message-ID: <50645583.3020809@intel.com> References: <1348666658-31345-1-git-send-email-vijay.a.purushothaman@intel.com> <1348666658-31345-9-git-send-email-vijay.a.purushothaman@intel.com> <20120926143818.GL1980@bremse> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id F3CB19E8C1 for ; Thu, 27 Sep 2012 06:32:54 -0700 (PDT) In-Reply-To: <20120926143818.GL1980@bremse> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel Graphics List-Id: intel-gfx@lists.freedesktop.org On 9/26/2012 8:08 PM, Daniel Vetter wrote: > On Wed, Sep 26, 2012 at 07:07:37PM +0530, Vijay Purushothaman wrote: >> Fixed min, max vco limits for VLV HDMI. Also fixed correct register >> offset for VLV_VIDEO_DIP_CTL_A >> >> Signed-off-by: Vijay Purushothaman >> Signed-off-by: Gajanan Bhat >> Signed-off-by: Ben Widawsky > > Patch splitup bikeshed: Either split up the dip reg fix into its own > patch, or make the commit headline more generic (e.g "fixup HDMI output on > vlv") with the details of the fix ("fixup vco limits and dip ctl reg") in > the commit message. I'll bikeshed the headline when applying. > -Daniel > I will change the commit headline. Thanks. >> --- >> drivers/gpu/drm/i915/i915_reg.h | 2 +- >> drivers/gpu/drm/i915/intel_display.c | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h >> index e421847..d4ed30e 100644 >> --- a/drivers/gpu/drm/i915/i915_reg.h >> +++ b/drivers/gpu/drm/i915/i915_reg.h >> @@ -3687,7 +3687,7 @@ >> #define TVIDEO_DIP_DATA(pipe) _PIPE(pipe, _VIDEO_DIP_DATA_A, _VIDEO_DIP_DATA_B) >> #define TVIDEO_DIP_GCP(pipe) _PIPE(pipe, _VIDEO_DIP_GCP_A, _VIDEO_DIP_GCP_B) >> >> -#define VLV_VIDEO_DIP_CTL_A 0x60220 >> +#define VLV_VIDEO_DIP_CTL_A 0x60200 >> #define VLV_VIDEO_DIP_DATA_A 0x60208 >> #define VLV_VIDEO_DIP_GDCP_PAYLOAD_A 0x60210 >> >> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c >> index aee6151..647e311 100644 >> --- a/drivers/gpu/drm/i915/intel_display.c >> +++ b/drivers/gpu/drm/i915/intel_display.c >> @@ -380,7 +380,7 @@ static const intel_limit_t intel_limits_vlv_dac = { >> >> static const intel_limit_t intel_limits_vlv_hdmi = { >> .dot = { .min = 20000, .max = 165000 }, >> - .vco = { .min = 5994000, .max = 4000000 }, >> + .vco = { .min = 4000000, .max = 5994000}, >> .n = { .min = 1, .max = 7 }, >> .m = { .min = 60, .max = 300 }, /* guess */ >> .m1 = { .min = 2, .max = 3 }, >> -- >> 1.7.9.5 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx >