From: Richard Henderson <rth@twiddle.net>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>,
patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 2/2] tcg/arm: Implement movcond_i32
Date: Thu, 27 Sep 2012 07:32:38 -0700 [thread overview]
Message-ID: <50646386.1010102@twiddle.net> (raw)
In-Reply-To: <5063F326.4070508@redhat.com>
On 09/26/2012 11:33 PM, Paolo Bonzini wrote:
> Should you make tcg/optimize.c prefer "movcond a, a, b" to "movcond a,
> b, a", similar to commit c2b0e2f (tcg/optimize: prefer the "op a, a, b"
> form for commutative ops, 2012-09-19)?
I explicitly went with "a, b, a" because I find it is easier to
reason with positive logic (move-if-true) than negative logic.
r~
next prev parent reply other threads:[~2012-09-27 14:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 18:48 [Qemu-devel] [PATCH 0/2] tcg/arm: Implement movcond_i32 Peter Maydell
2012-09-26 18:48 ` [Qemu-devel] [PATCH 1/2] tcg/arm: Factor out code to emit immediate or reg-reg op Peter Maydell
2012-09-26 19:01 ` Richard Henderson
2012-09-26 19:46 ` Peter Maydell
2012-09-27 13:01 ` Peter Maydell
2012-09-27 19:52 ` Aurelien Jarno
2012-09-26 18:48 ` [Qemu-devel] [PATCH 2/2] tcg/arm: Implement movcond_i32 Peter Maydell
2012-09-27 6:33 ` Paolo Bonzini
2012-09-27 14:32 ` Richard Henderson [this message]
2012-09-27 19:53 ` Aurelien Jarno
2012-10-12 17:07 ` [Qemu-devel] [PATCH 0/2] " Peter Maydell
2012-10-16 23:24 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50646386.1010102@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.