From: Saul Wold <sgw@linux.intel.com>
To: Phil Blundell <philb@gnu.org>
Cc: openembedded-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] package_ipk: Remove spurious '-i' in grep command for log_check
Date: Thu, 27 Sep 2012 08:53:10 -0700 [thread overview]
Message-ID: <50647666.9040003@linux.intel.com> (raw)
In-Reply-To: <1348660520.31293.104.camel@phil-desktop>
On 09/26/2012 04:55 AM, Phil Blundell wrote:
> ipk_log_check uses a case-sensitive grep (which is correct) when deciding
> whether there were any errors or not. But if it decides that there were, it
> then uses a case-insensitive grep to display them. This results in a large
> amount of irrelevant and confusing output which makes it hard to see the real
> errors amongst the noise.
>
> Suppress this by removing the unwanted -i.
>
> Signed-off-by: Phil Blundell <pb@pbcl.net>
> ---
> meta/classes/package_ipk.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/package_ipk.bbclass b/meta/classes/package_ipk.bbclass
> index efe299e..59cb856 100644
> --- a/meta/classes/package_ipk.bbclass
> +++ b/meta/classes/package_ipk.bbclass
> @@ -182,7 +182,7 @@ ipk_log_check() {
> then
> echo "log_check: There were error messages in the logfile"
> printf "log_check: Matched keyword: [$keyword_die]\n\n"
> - echo "$lf_txt" | grep -v log_check | grep -C 5 -i "$keyword_die"
> + echo "$lf_txt" | grep -v log_check | grep -C 5 "$keyword_die"
> echo ""
> do_exit=1
> fi
>
Merged into OE-Core
Thanks
Sau!
prev parent reply other threads:[~2012-09-27 16:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 11:55 [PATCH] package_ipk: Remove spurious '-i' in grep command for log_check Phil Blundell
2012-09-27 15:53 ` Saul Wold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50647666.9040003@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=philb@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.