Re: [Qemu-devel] Bug#688964: qemu-kvm: Fedora 17 guest hangs on boot with soft lockup in udevd

[Jan Kiszka <jan.kiszka@siemens.com>]

On 2012-09-27 20:43, Michael Tokarev wrote:
> On 27.09.2012 22:28, Jan Kiszka wrote:
> []
>>> --- a/hw/intel-hda.c
>>> +++ b/hw/intel-hda.c
>>> @@ -1107,6 +1107,9 @@ static void intel_hda_reset(DeviceState *dev)
>>>      DeviceState *qdev;
>>>      HDACodecDevice *cdev;
>>>
>>> +    if (d->msi) {
>>> +        msi_reset(&d->pci);
>>> +    }
>>>      intel_hda_regs_reset(d);
>>>      d->wall_base_ns = qemu_get_clock_ns(vm_clock);
>>>
>>> which is exactly about this hda thing.  I'm CC'ing relevant
>>> people here.
>>
>> I suppose we are resetting the MSI configuration also in cases here
>> where only the HDA internals are supposed to be reset (when called from
>> intel_hda_set_g_ctl).
> 
> Hmm.  I was looking at this code already (but i don't know the machinery
> anyway).  Here it is (I addedd two printfs in obvious places):
> 
> in intel_hda_reset
> calling intel_hda_reset from intel_hda_set_g_ctl
> in intel_hda_reset
> (at this time it hangs in guest).
> 
> The following patch fixes it.  Is it correct? :)
> 

It looks ok to me.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux