All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2 4/4] iw: pkg-config nitpicking
Date: Thu, 27 Sep 2012 23:40:54 +0200	[thread overview]
Message-ID: <5064C7E6.3080005@mind.be> (raw)
In-Reply-To: <1348656522-13698-4-git-send-email-gustavo@zacarias.com.ar>

On 26/09/12 12:48, Gustavo Zacarias wrote:
> Since we're now using pkgconf with a wrapper script we no longer need to
> pass PKG_CONFIG_PATH to pkg-config to do the right thing.
> Also point PKG_CONFIG to PKG_CONFIG_HOST_BINARY rather than the
> hardcoded option.
>
> Signed-off-by: Gustavo Zacarias<gustavo@zacarias.com.ar>
> ---
>   package/iw/iw.mk |    4 +---
>   1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/package/iw/iw.mk b/package/iw/iw.mk
> index b1a86b3..af11140 100644
> --- a/package/iw/iw.mk
> +++ b/package/iw/iw.mk
> @@ -9,9 +9,7 @@ IW_SOURCE = iw-$(IW_VERSION).tar.bz2
>   IW_SITE = http://wireless.kernel.org/download/iw
>   IW_DEPENDENCIES = host-pkgconf libnl
>   IW_CONFIG = $(IW_DIR)/.config
> -IW_MAKE_ENV = PKG_CONFIG_PATH="$(STAGING_DIR)/usr/lib/pkgconfig" \
> -	PKG_CONFIG="$(HOST_DIR)/usr/bin/pkg-config" \
> -	GIT_DIR=$(IW_DIR)
> +IW_MAKE_ENV = PKG_CONFIG="$(PKG_CONFIG_HOST_BINARY)"
>
>   ifeq ($(BR2_PREFER_STATIC_LIB),y)
>   # libnl needs pthread/m, so we need to explicitly with them when static

Doesn't removing GIT_DIR break version.sh?

Regards,
Arnout

-- 

Arnout Vandecappelle             arnout dot vandecappelle at essensium dot com
Senior Embedded Software Architect . . +32-16-286540 . +32-478-010353 (mobile)
Essensium, Mind division . . . . . . . . . . . . . . . . . http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium . . . . . . . . BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 31BB CF53 8660 6F88 345D 54CC A836 5879 20D7 CF43

  reply	other threads:[~2012-09-27 21:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-26 10:48 [Buildroot] [PATCHv2 1/4] pkgconf: new package Gustavo Zacarias
2012-09-26 10:48 ` [Buildroot] [PATCHv2 2/4] packages: switch to pkgconf Gustavo Zacarias
2012-09-26 10:48 ` [Buildroot] [PATCHv2 3/4] pkg-config: remove package Gustavo Zacarias
2012-09-26 10:48 ` [Buildroot] [PATCHv2 4/4] iw: pkg-config nitpicking Gustavo Zacarias
2012-09-27 21:40   ` Arnout Vandecappelle [this message]
2012-09-27 22:27     ` Gustavo Zacarias
2012-09-28 14:12       ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5064C7E6.3080005@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.