From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH] dma-buf: might_sleep() in dma_buf_unmap_attachment() Date: Fri, 28 Sep 2012 09:39:00 +0200 Message-ID: <50655414.2060400@canonical.com> References: <1348817383-30286-1-git-send-email-rob.clark@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1348817383-30286-1-git-send-email-rob.clark@linaro.org> Sender: linux-media-owner@vger.kernel.org To: Rob Clark Cc: dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-media@vger.kernel.org, patches@linaro.org, daniel.vetter@ffwll.ch, sumit.semwal@linaro.org, Rob Clark List-Id: dri-devel@lists.freedesktop.org Op 28-09-12 09:29, Rob Clark schreef: > From: Rob Clark > > We never really clarified if unmap could be done in atomic context. > But since mapping might require sleeping, this implies mutex in use > to synchronize mapping/unmapping, so unmap could sleep as well. Add > a might_sleep() to clarify this. > > Signed-off-by: Rob Clark > Acked-by: Daniel Vetter > --- > drivers/base/dma-buf.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/base/dma-buf.c b/drivers/base/dma-buf.c > index c30f3e1..877eacb 100644 > --- a/drivers/base/dma-buf.c > +++ b/drivers/base/dma-buf.c > @@ -298,6 +298,8 @@ void dma_buf_unmap_attachment(struct dma_buf_attachment *attach, > struct sg_table *sg_table, > enum dma_data_direction direction) > { > + might_sleep(); > + > if (WARN_ON(!attach || !attach->dmabuf || !sg_table)) > return; > Looks good to me! Reviewed-by: Maarten Lankhorst