From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylwester Nawrocki Date: Fri, 28 Sep 2012 08:25:39 +0000 Subject: Re: [PATCH V3] video: exynos_dp: Add device tree support to DP driver Message-Id: <50655F03.6000700@samsung.com> List-Id: References: <1348515385-22332-1-git-send-email-ajaykumar.rs@samsung.com> <50645848.6080102@gmail.com> <000601cd9d0d$c3296ca0$497c45e0$%han@samsung.com> <1511551.R6uMubmq1B@flatron> In-Reply-To: <1511551.R6uMubmq1B@flatron> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jingoo Han Cc: Tomasz Figa , 'Ajay Kumar' , linux-samsung-soc@vger.kernel.org, linux-fbdev@vger.kernel.org, FlorianSchandinat@gmx.de, thomas.ab@samsung.com, 'devicetree-discuss' On 09/28/2012 08:48 AM, Tomasz Figa wrote: >>>> + display-port-controller { >>>> + compatible = "samsung,exynos5-dp"; >>>> + reg =<0x145B0000 0x10000>; >>>> + interrupts =<10 3>; >>>> + interrupt-parent =<&combiner>; >>>> + dp_phy =<&dptx_phy>; >>> >>> Shouldn't it be "samsung,dp_phy" ? >> >> Do you mean this ? It is not working. >> + dp_phy = "samsung,dp_phy"; > > I believe he meant: > > -+ dp_phy =<&dptx_phy>; > ++ samsung,dp_phy =<&dptx_phy>; > > to mark that this is a Samsung-specific property. Yes, that's what I meant. Sorry for imprecise wording. Regards, Sylwester From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylwester Nawrocki Subject: Re: [PATCH V3] video: exynos_dp: Add device tree support to DP driver Date: Fri, 28 Sep 2012 10:25:39 +0200 Message-ID: <50655F03.6000700@samsung.com> References: <1348515385-22332-1-git-send-email-ajaykumar.rs@samsung.com> <50645848.6080102@gmail.com> <000601cd9d0d$c3296ca0$497c45e0$%han@samsung.com> <1511551.R6uMubmq1B@flatron> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout2.w1.samsung.com ([210.118.77.12]:13648 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751247Ab2I1IZm (ORCPT ); Fri, 28 Sep 2012 04:25:42 -0400 In-reply-to: <1511551.R6uMubmq1B@flatron> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Jingoo Han Cc: Tomasz Figa , 'Ajay Kumar' , linux-samsung-soc@vger.kernel.org, linux-fbdev@vger.kernel.org, FlorianSchandinat@gmx.de, thomas.ab@samsung.com, 'devicetree-discuss' On 09/28/2012 08:48 AM, Tomasz Figa wrote: >>>> + display-port-controller { >>>> + compatible = "samsung,exynos5-dp"; >>>> + reg =<0x145B0000 0x10000>; >>>> + interrupts =<10 3>; >>>> + interrupt-parent =<&combiner>; >>>> + dp_phy =<&dptx_phy>; >>> >>> Shouldn't it be "samsung,dp_phy" ? >> >> Do you mean this ? It is not working. >> + dp_phy = "samsung,dp_phy"; > > I believe he meant: > > -+ dp_phy =<&dptx_phy>; > ++ samsung,dp_phy =<&dptx_phy>; > > to mark that this is a Samsung-specific property. Yes, that's what I meant. Sorry for imprecise wording. Regards, Sylwester