From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Fioravante Subject: Re: [PATCH 05/11] add CONFIG_XC conditional Date: Fri, 28 Sep 2012 09:59:37 -0400 Message-ID: <5065AD49.7040101@jhuapl.edu> References: <1348765802-11314-1-git-send-email-matthew.fioravante@jhuapl.edu> <1348765802-11314-5-git-send-email-matthew.fioravante@jhuapl.edu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8001752028130860862==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap Cc: "samuel.thibault@ens-lyon.org" , "Ian.Campbell@citrix.com" , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org This is a cryptographically signed message in MIME format. --===============8001752028130860862== Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha1; boundary="------------ms080606040504060300050006" This is a cryptographically signed message in MIME format. --------------ms080606040504060300050006 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 09/28/2012 07:18 AM, George Dunlap wrote: > On Thu, Sep 27, 2012 at 6:09 PM, Matthew Fioravante > wrote: >> This patch adds a CONFIG_XC option to mini-os, to allow conditional >> support for libxc for mini-os domains. >> >> Signed-off-by: Matthew Fioravante >> Acked-by: Samuel Thibault > Hmm... Samuel said, "Apart from that, Acked-by:", but you didn't > address the "that" that he mentioned. In that circumstance, I don't > think addding the "Acked-by" to the commit message is really > appropriate -- it implies that the patch was approved as-is, when in > fact he was only saying that he agreed that these changes were all > right, but that perhaps there needed to be more. > > Can you address his question? I'll look into it. I assumed Acked-by in the message meant it was officially acked. Sorry about that. > -George > >> diff --git a/extras/mini-os/Makefile b/extras/mini-os/Makefile >> index c425f76..b4236e8 100644 >> --- a/extras/mini-os/Makefile >> +++ b/extras/mini-os/Makefile >> @@ -27,6 +27,7 @@ CONFIG_FBFRONT ?=3D y >> CONFIG_KBDFRONT ?=3D y >> CONFIG_CONSFRONT ?=3D y >> CONFIG_XENBUS ?=3D y >> +CONFIG_XC ?=3Dy >> CONFIG_LWIP ?=3D $(lwip) >> >> # Export config items as compiler directives >> diff --git a/extras/mini-os/lib/sys.c b/extras/mini-os/lib/sys.c >> index 7ddbbf8..6cb97b1 100644 >> --- a/extras/mini-os/lib/sys.c >> +++ b/extras/mini-os/lib/sys.c >> @@ -397,6 +397,7 @@ int close(int fd) >> return res; >> } >> #endif >> +#ifdef CONFIG_XC >> case FTYPE_XC: >> minios_interface_close_fd(fd); >> return 0; >> @@ -406,6 +407,7 @@ int close(int fd) >> case FTYPE_GNTMAP: >> minios_gnttab_close_fd(fd); >> return 0; >> +#endif >> #ifdef CONFIG_NETFRONT >> case FTYPE_TAP: >> shutdown_netfront(files[fd].tap.dev); >> @@ -1195,10 +1197,13 @@ void *mmap(void *start, size_t length, int pro= t, int flags, int fd, off_t offset >> >> if (fd =3D=3D -1) >> return map_zero(n, 1); >> +#ifdef CONFIG_XC >> else if (files[fd].type =3D=3D FTYPE_XC) { >> unsigned long zero =3D 0; >> return map_frames_ex(&zero, n, 0, 0, 1, DOMID_SELF, NULL, 0);= >> - } else if (files[fd].type =3D=3D FTYPE_MEM) { >> + } >> +#endif >> + else if (files[fd].type =3D=3D FTYPE_MEM) { >> unsigned long first_mfn =3D offset >> PAGE_SHIFT; >> return map_frames_ex(&first_mfn, n, 0, 1, 1, DOMID_IO, NULL, = _PAGE_PRESENT|_PAGE_RW); >> } else ASSERT(0); >> -- >> 1.7.9.5 >> >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xen.org >> http://lists.xen.org/xen-devel --------------ms080606040504060300050006 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIDyjCC A8YwggMvoAMCAQICBD/xyf0wDQYJKoZIhvcNAQEFBQAwLzELMAkGA1UEBhMCVVMxDzANBgNV BAoTBkpIVUFQTDEPMA0GA1UECxMGQklTRENBMB4XDTEwMDYxMTE4MjIwNloXDTEzMDYxMTE4 NTIwNlowZjELMAkGA1UEBhMCVVMxDzANBgNVBAoTBkpIVUFQTDEPMA0GA1UECxMGUGVvcGxl MTUwFgYDVQQLEw9WUE5Hcm91cC1CSVNEQ0EwGwYDVQQDExRNYXR0aGV3IEUgRmlvcmF2YW50 ZTCBnzANBgkqhkiG9w0BAQEFAAOBjQAwgYkCgYEAnpbwVSP6o1Nb5lcW7dd3yTo9iBJdi7qz 4nANOMFPK7JOy5npKN1iiousl28U/scUJES55gPwAWYJK3uVyQAsA4adgDKi5DoD1UHDQEwp bY7iHLJeq0NPr4BqYNqnCFPbE6HC8zSJrr4qKn+gVUQT39SIFqdiIPJwZL8FYTRQ/zsCAwEA AaOCAbYwggGyMAsGA1UdDwQEAwIHgDArBgNVHRAEJDAigA8yMDEwMDYxMTE4MjIwNlqBDzIw MTIwNzE3MjI1MjA2WjAbBg0rBgEEAbMlCwMBAQEBBAoWCGZpb3JhbWUxMBsGDSsGAQQBsyUL AwEBAQIEChIIMDAxMDQyNjEwWAYJYIZIAYb6ax4BBEsMSVRoZSBwcml2YXRlIGtleSBjb3Jy ZXNwb25kaW5nIHRvIHRoaXMgY2VydGlmaWNhdGUgbWF5IGhhdmUgYmVlbiBleHBvcnRlZC4w KAYDVR0RBCEwH4EdTWF0dGhldy5GaW9yYXZhbnRlQGpodWFwbC5lZHUwUgYDVR0fBEswSTBH oEWgQ6RBMD8xCzAJBgNVBAYTAlVTMQ8wDQYDVQQKEwZKSFVBUEwxDzANBgNVBAsTBkJJU0RD QTEOMAwGA1UEAxMFQ1JMNTYwHwYDVR0jBBgwFoAUCDUpmxH52EU2CyWmF2EJMB1yqeswHQYD VR0OBBYEFO6LYxg6r9wHZ+zdQtBHn1dZ/YTNMAkGA1UdEwQCMAAwGQYJKoZIhvZ9B0EABAww ChsEVjcuMQMCBLAwDQYJKoZIhvcNAQEFBQADgYEAJO9HQh4YNChVLzuZqK5ARJARD8JoujGZ fdo75quvg2jXFQe2sEjvLnxJZgm/pv8fdZakq48CWwjYHKuvIp7sDjTEsQfo+y7SpN/N2NvJ WU5SqfK1VgYtNLRRoGJUB5Q1aZ+Dg95g3kqpyfpUMISJL8IKVLtJVfN4fggFVUYZ9wwxggGr MIIBpwIBATA3MC8xCzAJBgNVBAYTAlVTMQ8wDQYDVQQKEwZKSFVBUEwxDzANBgNVBAsTBkJJ U0RDQQIEP/HJ/TAJBgUrDgMCGgUAoIHLMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJ KoZIhvcNAQkFMQ8XDTEyMDkyODEzNTkzN1owIwYJKoZIhvcNAQkEMRYEFN1gF7m3AmBBp0yr +M10EFo9Oy5RMGwGCSqGSIb3DQEJDzFfMF0wCwYJYIZIAWUDBAEqMAsGCWCGSAFlAwQBAjAK BggqhkiG9w0DBzAOBggqhkiG9w0DAgICAIAwDQYIKoZIhvcNAwICAUAwBwYFKw4DAgcwDQYI KoZIhvcNAwICASgwDQYJKoZIhvcNAQEBBQAEgYBOVd7hqhBWY+RvcDj5bm8NgYfbJQlkwwQ8 re8mg1Tn6CWoRRm4D6yCwVNsCLav6BaDV6B9kn2VNxXCKE0++mcs2JYnqcwK5i//ocr+8fAh jr9b5l3i4DDlgkIlWN0hd0BfsT3/ibc4hxZLhqVLoWZK3xWvi61Yx9XyJJDnIZW+cQAAAAAA AA== --------------ms080606040504060300050006-- --===============8001752028130860862== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============8001752028130860862==--