diff for duplicates of <5066D2F6.10800@bfs.de> diff --git a/a/1.txt b/N1/1.txt index 0944098..a2f4059 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -16,10 +16,11 @@ Am 29.09.2012 09:12, schrieb Dan Carpenter: > } > > /* Default if filename is empty string */ -> - if (strcmp(dev->input_filename, "") = 0) { -> + if (strcmp(dev->_filename, "") = 0) { +> - if (strcmp(dev->input_filename, "") == 0) { +> + if (strcmp(dev->_filename, "") == 0) { > if (dev->_isNTSC) { -> dev->_filename > (dev->_pixel_format = PIXEL_FRMT_411) ? +> dev->_filename = +> (dev->_pixel_format == PIXEL_FRMT_411) ? > diff --git a/drivers/media/pci/cx25821/cx25821-video-upstream-ch2.c b/drivers/media/pci/cx25821/cx25821-video-upstream-ch2.c > index c8c94fb..d33fc1a 100644 > --- a/drivers/media/pci/cx25821/cx25821-video-upstream-ch2.c @@ -28,15 +29,15 @@ Am 29.09.2012 09:12, schrieb Dan Carpenter: > } > > /* Default if filename is empty string */ -> - if (strcmp(dev->input_filename_ch2, "") = 0) { -> + if (strcmp(dev->_filename_ch2, "") = 0) { +> - if (strcmp(dev->input_filename_ch2, "") == 0) { +> + if (strcmp(dev->_filename_ch2, "") == 0) { > if (dev->_isNTSC_ch2) { -> dev->_filename_ch2 = (dev->_pixel_format_ch2 = +> dev->_filename_ch2 = (dev->_pixel_format_ch2 == > PIXEL_FRMT_411) ? "/root/vid411.yuv" : > In this case stcmp seems a bit of a overkill. A simple -*(dev->_filename_ch2) = 0 +*(dev->_filename_ch2) == 0 should be ok ? re, diff --git a/a/content_digest b/N1/content_digest index f9f7326..e590c2d 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\020120929071253.GD10993@elgon.mountain\0" "From\0walter harms <wharms@bfs.de>\0" "Subject\0Re: [patch] [media] cx25821: testing the wrong variable\0" - "Date\0Sat, 29 Sep 2012 10:52:38 +0000\0" + "Date\0Sat, 29 Sep 2012 12:52:38 +0200\0" "To\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Cc\0Mauro Carvalho Chehab <mchehab@infradead.org>" Leonid V. Fedorenchik <leonidsbox@gmail.com> @@ -29,10 +29,11 @@ "> \t}\n" "> \n" "> \t/* Default if filename is empty string */\n" - "> -\tif (strcmp(dev->input_filename, \"\") = 0) {\n" - "> +\tif (strcmp(dev->_filename, \"\") = 0) {\n" + "> -\tif (strcmp(dev->input_filename, \"\") == 0) {\n" + "> +\tif (strcmp(dev->_filename, \"\") == 0) {\n" "> \t\tif (dev->_isNTSC) {\n" - "> \t\t\tdev->_filename > \t\t\t\t(dev->_pixel_format = PIXEL_FRMT_411) ?\n" + "> \t\t\tdev->_filename =\n" + "> \t\t\t\t(dev->_pixel_format == PIXEL_FRMT_411) ?\n" "> diff --git a/drivers/media/pci/cx25821/cx25821-video-upstream-ch2.c b/drivers/media/pci/cx25821/cx25821-video-upstream-ch2.c\n" "> index c8c94fb..d33fc1a 100644\n" "> --- a/drivers/media/pci/cx25821/cx25821-video-upstream-ch2.c\n" @@ -41,18 +42,18 @@ "> \t}\n" "> \n" "> \t/* Default if filename is empty string */\n" - "> -\tif (strcmp(dev->input_filename_ch2, \"\") = 0) {\n" - "> +\tif (strcmp(dev->_filename_ch2, \"\") = 0) {\n" + "> -\tif (strcmp(dev->input_filename_ch2, \"\") == 0) {\n" + "> +\tif (strcmp(dev->_filename_ch2, \"\") == 0) {\n" "> \t\tif (dev->_isNTSC_ch2) {\n" - "> \t\t\tdev->_filename_ch2 = (dev->_pixel_format_ch2 =\n" + "> \t\t\tdev->_filename_ch2 = (dev->_pixel_format_ch2 ==\n" "> \t\t\t\tPIXEL_FRMT_411) ? \"/root/vid411.yuv\" :\n" ">\n" "\n" "In this case stcmp seems a bit of a overkill. A simple\n" - "*(dev->_filename_ch2) = 0\n" + "*(dev->_filename_ch2) == 0\n" "should be ok ?\n" "\n" "re,\n" wh -6d9aba23632c116b48509820b0c9b35be66185c26bc907f46d545632d8b813bc +409c7d73667b58913771e071840ffa258cc4b209a3c98482b0d96ef948004e30
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.