All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Zacarias <gustavo@zacarias.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv3 1/4] pkgconf: new package
Date: Sat, 29 Sep 2012 09:53:48 -0300	[thread overview]
Message-ID: <5066EF5C.4030802@zacarias.com.ar> (raw)
In-Reply-To: <50640642.8020407@mind.be>

On 09/27/12 04:54, Arnout Vandecappelle wrote:
>> +PKG_CONFIG_PATH=${PKG_CONFIG_PATH:- at PKG_CONFIG_PATH@}
>> PKG_CONFIG_SYSROOT_DIR=${PKG_CONFIG_SYSROOT_DIR:- at STAGING_DIR@}
>> @HOST_DIR@/usr/bin/pkgconf $@
> 
>  Actually, instead of @HOST_DIR@/usr/bin, it's better to use $(dirname $0).
> That way it's relocatable.

Yes, that's cool.
I'm rolling back to not allowing overrides to PKG_CONFIG_PATH and
PKG_CONFIG_SYSROOT_DIR since at least one package (sshfs) behaves badly.
Case in point is it does export
PKG_CONFIG_PATH=/usr/local/lib/pkgconfig:$PKG_CONFIG_PATH which you can
guess where it goes.
I could append instead of replace, but again, in general for the time
being i see no real benefit in allowing it, so we'd end with:

PKG_CONFIG_PATH=@PKG_CONFIG_PATH@ PKG_CONFIG_SYSROOT_DIR=@STAGING_DIR@
$(dirname $0)/pkgconf $@

Like in v1 but with your dirname recommendation.
The other fix scenario would be to make all the packages use
$(TARGET_MAKE_ENV) and fill the PKG_CONFIG* variables there.
Regards.

      parent reply	other threads:[~2012-09-29 12:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-26 10:54 [Buildroot] [PATCHv3 1/4] pkgconf: new package Gustavo Zacarias
2012-09-27  7:54 ` Arnout Vandecappelle
2012-09-27  8:09   ` Thomas Petazzoni
2012-09-27  8:20     ` Arnout Vandecappelle
2012-09-27  8:25       ` Thomas Petazzoni
2012-09-27  8:30         ` Arnout Vandecappelle
2012-09-27 13:24           ` Thomas Petazzoni
2012-09-29 12:53   ` Gustavo Zacarias [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5066EF5C.4030802@zacarias.com.ar \
    --to=gustavo@zacarias.com.ar \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.