From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58447)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1TI1kI-0001AV-7k
	for qemu-devel@nongnu.org; Sat, 29 Sep 2012 14:26:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1TI1kH-0002OF-7u
	for qemu-devel@nongnu.org; Sat, 29 Sep 2012 14:26:34 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:40895)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1TI1kH-0002OB-1F
	for qemu-devel@nongnu.org; Sat, 29 Sep 2012 14:26:33 -0400
Message-ID: <50673D55.4030407@weilnetz.de>
Date: Sat, 29 Sep 2012 20:26:29 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1348942239-3081-1-git-send-email-rth@twiddle.net>
	<1348942239-3081-2-git-send-email-rth@twiddle.net>
In-Reply-To: <1348942239-3081-2-git-send-email-rth@twiddle.net>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/3] tcg-alpha: Fix type mismatch errors
 in	cpu_signal_handler.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>

Am 29.09.2012 20:10, schrieb Richard Henderson:
> Signed-off-by: Richard Henderson<rth@twiddle.net>
> ---
>   user-exec.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/user-exec.c b/user-exec.c
> index ef9b172..1635e4a 100644
> --- a/user-exec.c
> +++ b/user-exec.c
> @@ -352,8 +352,8 @@ int cpu_signal_handler(int host_signum, void *pinfo,
>   {
>       siginfo_t *info = pinfo;
>       struct ucontext *uc = puc;
> -    uint32_t *pc = uc->uc_mcontext.sc_pc;
> -    uint32_t insn = *pc;
> +    unsigned long pc = uc->uc_mcontext.sc_pc;
>    

I'd prefer uintptr_t instead of unsigned long.
Otherwise the following type cast is not portable
(even if that doesn't matter currently because
that code is not compiled with MinGW).

Yes, there is more similar code in user-exec.c.

> +    uint32_t insn = *(uint32_t *)pc;
>       int is_write = 0;
>
>       /* XXX: need kernel patch to get write flag faster */
>    


Regards

Stefan W.