From: Arne Jansen <sensille@gmx.net>
To: Alexander Block <ablock84@googlemail.com>
Cc: Li Zefan <lizefan@huawei.com>, chandan r <chandanrmail@gmail.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: Add code to support file creation time.
Date: Sun, 30 Sep 2012 10:13:14 +0200 [thread overview]
Message-ID: <5067FF1A.5060804@gmx.net> (raw)
In-Reply-To: <CAB9VWqCjsAUd26-HsmHMAskx-LxO0ZyNxRk+4cQvaAbxQ2GiYA@mail.gmail.com>
On 07/04/12 13:04, Alexander Block wrote:
> On Wed, Jul 4, 2012 at 9:56 AM, Li Zefan <lizefan@huawei.com> wrote:
>> On 2012/7/4 15:18, chandan r wrote:
>>
>>> This patch adds a new member to the 'struct btrfs_inode' structure to hold
>>> the file creation time.
>>>
>>
>>
>> Well, how do users use this file creation time? There's no syscall and there's
>> no ioctl that exports this information. That xstat syscall hasn't been accepted,
>> so you can revise and repost the patch when you see it happens.
> In my opinion we should still include this patch. Currently, otime is never even
> initialized, having undefined values. If it ever gets possible to
> access otime, we
> would at least have some inodes with valid otime fields.
I'll second that, even if by now the fields get correctly initialized.
Why should we zero the fields instead of setting them to the correct
values?
-Arne
prev parent reply other threads:[~2012-09-30 8:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-04 7:18 [PATCH] Btrfs: Add code to support file creation time chandan r
2012-07-04 7:56 ` Li Zefan
2012-07-04 11:04 ` Alexander Block
2012-07-05 1:07 ` Li Zefan
2012-07-05 1:52 ` Alexander Block
2012-07-10 5:36 ` Li Zefan
2012-09-30 8:13 ` Arne Jansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5067FF1A.5060804@gmx.net \
--to=sensille@gmx.net \
--cc=ablock84@googlemail.com \
--cc=chandanrmail@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=lizefan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.