From: "Grégor Boirie" <gregor.boirie@parrot.com>
To: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: m25p80: missing MTD owner
Date: Mon, 1 Oct 2012 10:01:15 +0200 [thread overview]
Message-ID: <50694DCB.6010303@parrot.com> (raw)
Hi all,
It seems possible to unload m25p80 module while a JFFS2 partition is
still mounted onto flash. This produces oops when MTD layer tries to
access underlying device later on.
A quick look at m25p_probe shows that "owner" field of allocated mtd
device structure is left uninitialized, preventing MTD layer from
incrementing module usage count. This patch for v3.4.11 solves the issue
for me :
@@ -873,6 +873,7 @@ static int __devinit m25p_probe(struct spi_device *spi)
else
flash->mtd.name = dev_name(&spi->dev);
+ flash->mtd.owner = THIS_MODULE;
flash->mtd.type = MTD_NORFLASH;
flash->mtd.writesize = 1;
flash->mtd.flags = MTD_CAP_NORFLASH;
Regards.
--
Grégor Boirie
Software engineer
R&D / OS platform
tel +33 1 48 03 73 24
-----------------------------------------
Parrot
174, quai de Jemmapes
75010 Paris France
tel + 33 1 48 03 60 60
fax + 33 1 48 03 06 66
-----------------------------------------
http://www.parrot.com
next reply other threads:[~2012-10-01 8:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-01 8:01 Grégor Boirie [this message]
2012-10-05 0:51 ` m25p80: missing MTD owner Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50694DCB.6010303@parrot.com \
--to=gregor.boirie@parrot.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.