From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: qemu-kvm: remove "boot=on|off" drive parameter compatibility
Date: Mon, 01 Oct 2012 10:05:21 +0200
Message-ID: <50694EC1.8060006@siemens.com>
References: <20120930191146.GA20012@amt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: kvm <kvm@vger.kernel.org>
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from david.siemens.de ([192.35.17.14]:29819 "EHLO david.siemens.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750953Ab2JAIF0 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 1 Oct 2012 04:05:26 -0400
In-Reply-To: <20120930191146.GA20012@amt.cnet>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 2012-09-30 21:11, Marcelo Tosatti wrote:
> 
> Option is deprecated and warning has been in place for one year.

Do we really care about such cosmetics? What is the big plan for
qemu-kvm now? For 1.3 and then beyond?

Jan

> 
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
> 
> diff --git a/blockdev.c b/blockdev.c
> index 4a5266e..7c83baa 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -432,12 +432,6 @@ DriveInfo *drive_init(QemuOpts *opts, int default_to_scsi)
>          return NULL;
>      }
>  
> -    if (qemu_opt_get(opts, "boot") != NULL) {
> -        fprintf(stderr, "qemu-kvm: boot=on|off is deprecated and will be "
> -                "ignored. Future versions will reject this parameter. Please "
> -                "update your scripts.\n");
> -    }
> -
>      on_write_error = BLOCK_ERR_STOP_ENOSPC;
>      if ((buf = qemu_opt_get(opts, "werror")) != NULL) {
>          if (type != IF_IDE && type != IF_SCSI && type != IF_VIRTIO && type != IF_NONE) {
> diff --git a/qemu-config.c b/qemu-config.c
> index 3eaee48..eba977e 100644
> --- a/qemu-config.c
> +++ b/qemu-config.c
> @@ -114,10 +114,6 @@ static QemuOptsList qemu_drive_opts = {
>              .name = "copy-on-read",
>              .type = QEMU_OPT_BOOL,
>              .help = "copy read data from backing file into image file",
> -        },{
> -            .name = "boot",
> -            .type = QEMU_OPT_BOOL,
> -            .help = "(deprecated, ignored)",
>          },
>          { /* end of list */ }
>      },
> 

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux